Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codenotify seems to include diff of all parents when there are merge commits #10

Open
felixfbecker opened this issue Jan 29, 2021 · 0 comments

Comments

@felixfbecker
Copy link
Contributor

When a branch contains a merge commit, e.g. because main was merged into the branch to update it, Codenotify seems to not only analyze the diff of commits on the branch line, but also the diff of commits on main. Example: https://github.com/sourcegraph/sourcegraph/pull/17521#issuecomment-765274334

I haven't looked at the code, but Git provides various command parameters that control to only include one line of parents in git diff and git log that may help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant