Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 500 response is missing CORS header #38

Open
Moongazer opened this issue Jul 30, 2021 · 0 comments
Open

Bug: 500 response is missing CORS header #38

Moongazer opened this issue Jul 30, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@Moongazer
Copy link
Contributor

Moongazer commented Jul 30, 2021

If an exception occurs, for example a custom operation-handler returns a wrong object type, the resulting 500 response is missing CORS headers. If the requesting front-end is running under another domain (e.g. during development http://localhost:8080/), the whole response incl. a possible error message is hided by the browser, which makes it very difficult to debug.

Possible solution: Also responses from the exception catch() blocks in SourceBroker\T3api\Dispatcher\Bootstrap::process() should call the processors $this->callProcessors(). Maybe this applies only for exceptions from the catch (Throwable $throwable) block.

@kszymukowicz kszymukowicz added this to the 4.0.0 milestone Apr 30, 2024
@kszymukowicz kszymukowicz added the bug Something isn't working label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants