Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When augmenting a DOM element, height is undefined #89

Open
KingScooty opened this issue Dec 6, 2016 · 1 comment
Open

When augmenting a DOM element, height is undefined #89

KingScooty opened this issue Dec 6, 2016 · 1 comment

Comments

@KingScooty
Copy link

<div class="test-context"></div>
var container = document.querySelectorAll('.test-context')[0];
var test = Sketch.augment(container);

As far as i'm aware, i should be able to augment an existing DOM element and manipulate said DOM element using CSS.

I seem to be getting the following error:

Cannot read property 'height' of undefined

On sketch.js 298, which looks like it's not getting the style.height correctly for DOM elements.

Am i missing a step? Or is this an error with Sketch?

@soulwire
Copy link
Owner

soulwire commented Jan 3, 2017

Looks like this could be a bug, yes—I'll look into that. Although for now it will work if you use create instead, passing in the container:

var test = Sketch.create({
  container: container
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants