Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no results, expecting an empty list #38

Open
wasperen2 opened this issue Jul 4, 2024 · 1 comment
Open

if no results, expecting an empty list #38

wasperen2 opened this issue Jul 4, 2024 · 1 comment

Comments

@wasperen2
Copy link

Describe the bug
When doing a .select(ids=[...]), for an _id that does not exist, one would expect an empty list rather than None

To Reproduce

import uuid
from typing import Optional

from pydantic import Field
from pydantic_redis import Store, RedisConfig, Model


class SomeModel(Model):
    _primary_key_field = "id"
    id: str = Field(
        default_factory=lambda: uuid.uuid4().hex,
    )
    name: str = Field()


store = Store(
    name="none should return a list too",
    redis_config=RedisConfig(host='localhost', port=6379, db=6)
)

store.register_model(SomeModel)

parent = SomeModel(name="bong bing")

SomeModel.insert(parent)

models_received = SomeModel.select(ids=["some none existing id"])
print(models_received)
assert isinstance(models_received, list)

Expected behavior
One would expect this assertion to pass. Instead, we get:

    assert isinstance(models_received, list)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
None
@wasperen2
Copy link
Author

If columns is specified, the select method does return an empty list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant