diff --git a/saidump/Makefile.am b/saidump/Makefile.am index 46c51d0fc..104c175d9 100644 --- a/saidump/Makefile.am +++ b/saidump/Makefile.am @@ -7,3 +7,7 @@ saidump_CPPFLAGS = $(CODE_COVERAGE_CPPFLAGS) saidump_CXXFLAGS = $(DBGFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS_COMMON) $(CODE_COVERAGE_CXXFLAGS) saidump_LDADD = -lhiredis -lswsscommon -lpthread -L$(top_srcdir)/meta/.libs -lsaimetadata -lsaimeta \ -L$(top_srcdir)/lib/.libs -lsairedis -lzmq $(CODE_COVERAGE_LIBS) + +noinst_LIBRARIES = libsaidump.a +libsaidump_a_SOURCES = saidump.cpp +AM_CPPFLAGS = -D_UNITTEST_ \ No newline at end of file diff --git a/saidump/saidump.cpp b/saidump/saidump.cpp index c655fc8a9..094de48b1 100644 --- a/saidump/saidump.cpp +++ b/saidump/saidump.cpp @@ -15,28 +15,14 @@ extern "C" { #include "meta/sai_serialize.h" #include "sairediscommon.h" #include "swss/json.hpp" - +#include "saidump.h" #include // TODO split to multiple cpp using namespace swss; using json = nlohmann::json; - -// Default value: 100 MB -constexpr int64_t RDB_JSON_MAX_SIZE = 1024 * 1024 * 100; - -struct CmdOptions -{ - bool skipAttributes; - bool dumpTempView; - bool dumpGraph; - std::string rdbJsonFile; - uint64_t rdbJSonSizeLimit; -}; - - -static CmdOptions g_cmdOptions; +CmdOptions g_cmdOptions; static std::map g_oid_map; void printUsage() @@ -451,7 +437,7 @@ void dumpGraph(const TableDump& td) /** * @brief Process the input JSON file to make sure it's a valid JSON file for the JSON library. */ -static sai_status_t preProcessFile(const std::string file_name) +sai_status_t preProcessFile(const std::string file_name) { SWSS_LOG_ENTER(); @@ -502,7 +488,7 @@ static sai_status_t preProcessFile(const std::string file_name) return SAI_STATUS_SUCCESS; } -static sai_status_t dumpFromRedisRdbJson(const std::string file_name) +sai_status_t dumpFromRedisRdbJson(const std::string file_name) { SWSS_LOG_ENTER(); diff --git a/saidump/saidump.h b/saidump/saidump.h new file mode 100755 index 000000000..b6145a87b --- /dev/null +++ b/saidump/saidump.h @@ -0,0 +1,19 @@ +#pragma once +#include + +// Default value: 100 MB +constexpr int64_t RDB_JSON_MAX_SIZE = 1024 * 1024 * 100; + +struct CmdOptions +{ + bool skipAttributes; + bool dumpTempView; + bool dumpGraph; + std::string rdbJsonFile; + uint64_t rdbJSonSizeLimit; +}; + +void printUsage(); +CmdOptions handleCmdLine(int argc, char **argv); +sai_status_t dumpFromRedisRdbJson(const std::string file_name); +sai_status_t preProcessFile(const std::string file_name); \ No newline at end of file diff --git a/unittest/saidump/Makefile.am b/unittest/saidump/Makefile.am index 2ee171537..0519d4ca6 100755 --- a/unittest/saidump/Makefile.am +++ b/unittest/saidump/Makefile.am @@ -6,8 +6,8 @@ LDADD_GTEST = -L/usr/src/gtest -lgtest -lgtest_main tests_SOURCES = main.cpp -tests_CXXFLAGS = $(DBGFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS_COMMON) -D_UNITTEST_ -tests_LDFLAGS = -Wl,-rpath,$(top_srcdir)/lib/.libs -Wl,-rpath,$(top_srcdir)/meta/.libs -tests_LDADD = $(LDADD_GTEST) -lhiredis -lswsscommon -lnl-genl-3 -lnl-nf-3 -lnl-route-3 -lnl-3 -lpthread -L$(top_srcdir)/lib/.libs -lsairedis -L$(top_srcdir)/meta/.libs -lsaimetadata -lsaimeta -lzmq $(CODE_COVERAGE_LIBS) +tests_CXXFLAGS = $(DBGFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS_COMMON) +tests_LDFLAGS = -D_UNITTEST_ +tests_LDADD = $(LDADD_GTEST) $(top_srcdir)/saidump/libsaidump.a -lhiredis -lswsscommon -lnl-genl-3 -lnl-nf-3 -lnl-route-3 -lnl-3 -lpthread -L$(top_srcdir)/lib/.libs -lsairedis -L$(top_srcdir)/meta/.libs -lsaimetadata -lsaimeta -lzmq $(CODE_COVERAGE_LIBS) TESTS = tests \ No newline at end of file diff --git a/unittest/saidump/main.cpp b/unittest/saidump/main.cpp index 295eb78aa..06a77b5d9 100755 --- a/unittest/saidump/main.cpp +++ b/unittest/saidump/main.cpp @@ -1,8 +1,10 @@ #include -#include "saidump.cpp" - +#include "meta/sai_serialize.h" +#include "saidump.h" #define ARGVN 5 +extern CmdOptions g_cmdOptions; + TEST(SaiDump, printUsage) { SWSS_LOG_ENTER(); @@ -26,7 +28,7 @@ TEST(SaiDump, handleCmdLine) g_cmdOptions = handleCmdLine(ARGVN, argv); delete[] argv; EXPECT_EQ(g_cmdOptions.rdbJsonFile, "./dump.json"); - EXPECT_EQ(g_cmdOptions.rdbJSonSizeLimit, 100 * 1024 * 1024); + EXPECT_EQ(g_cmdOptions.rdbJSonSizeLimit, RDB_JSON_MAX_SIZE); } TEST(SaiDump, dumpFromRedisRdbJson) diff --git a/unittest/saidump/tests b/unittest/saidump/tests deleted file mode 100755 index ead3fe2a4..000000000 --- a/unittest/saidump/tests +++ /dev/null @@ -1,210 +0,0 @@ -#! /bin/bash - -# tests - temporary wrapper script for .libs/tests -# Generated by libtool (GNU libtool) 2.4.6 Debian-2.4.6-9 -# -# The tests program cannot be directly executed until all the libtool -# libraries that it depends on are installed. -# -# This wrapper script should never be moved out of the build directory. -# If it is, it will not operate correctly. - -# Sed substitution that helps us do robust quoting. It backslashifies -# metacharacters that are still active within double-quoted strings. -sed_quote_subst='s|\([`"$\\]\)|\\\1|g' - -# Be Bourne compatible -if test -n "${ZSH_VERSION+set}" && (emulate sh) >/dev/null 2>&1; then - emulate sh - NULLCMD=: - # Zsh 3.x and 4.x performs word splitting on ${1+"$@"}, which - # is contrary to our usage. Disable this feature. - alias -g '${1+"$@"}'='"$@"' - setopt NO_GLOB_SUBST -else - case `(set -o) 2>/dev/null` in *posix*) set -o posix;; esac -fi -BIN_SH=xpg4; export BIN_SH # for Tru64 -DUALCASE=1; export DUALCASE # for MKS sh - -# The HP-UX ksh and POSIX shell print the target directory to stdout -# if CDPATH is set. -(unset CDPATH) >/dev/null 2>&1 && unset CDPATH - -relink_command="" - -# This environment variable determines our operation mode. -if test "$libtool_install_magic" = "%%%MAGIC variable%%%"; then - # install mode needs the following variables: - generated_by_libtool_version='2.4.6' - notinst_deplibs=' /sonic/src/sonic-sairedis/lib/.libs/libsairedis.la /sonic/src/sonic-sairedis/meta/.libs/libsaimetadata.la /sonic/src/sonic-sairedis/meta/.libs/libsaimeta.la' -else - # When we are sourced in execute mode, $file and $ECHO are already set. - if test "$libtool_execute_magic" != "%%%MAGIC variable%%%"; then - file="$0" - -# A function that is used when there is no print builtin or printf. -func_fallback_echo () -{ - eval 'cat <<_LTECHO_EOF -$1 -_LTECHO_EOF' -} - ECHO="printf %s\\n" - fi - -# Very basic option parsing. These options are (a) specific to -# the libtool wrapper, (b) are identical between the wrapper -# /script/ and the wrapper /executable/ that is used only on -# windows platforms, and (c) all begin with the string --lt- -# (application programs are unlikely to have options that match -# this pattern). -# -# There are only two supported options: --lt-debug and -# --lt-dump-script. There is, deliberately, no --lt-help. -# -# The first argument to this parsing function should be the -# script's ../../libtool value, followed by no. -lt_option_debug= -func_parse_lt_options () -{ - lt_script_arg0=$0 - shift - for lt_opt - do - case "$lt_opt" in - --lt-debug) lt_option_debug=1 ;; - --lt-dump-script) - lt_dump_D=`$ECHO "X$lt_script_arg0" | /bin/sed -e 's/^X//' -e 's%/[^/]*$%%'` - test "X$lt_dump_D" = "X$lt_script_arg0" && lt_dump_D=. - lt_dump_F=`$ECHO "X$lt_script_arg0" | /bin/sed -e 's/^X//' -e 's%^.*/%%'` - cat "$lt_dump_D/$lt_dump_F" - exit 0 - ;; - --lt-*) - $ECHO "Unrecognized --lt- option: '$lt_opt'" 1>&2 - exit 1 - ;; - esac - done - - # Print the debug banner immediately: - if test -n "$lt_option_debug"; then - echo "tests:tests:$LINENO: libtool wrapper (GNU libtool) 2.4.6 Debian-2.4.6-9" 1>&2 - fi -} - -# Used when --lt-debug. Prints its arguments to stdout -# (redirection is the responsibility of the caller) -func_lt_dump_args () -{ - lt_dump_args_N=1; - for lt_arg - do - $ECHO "tests:tests:$LINENO: newargv[$lt_dump_args_N]: $lt_arg" - lt_dump_args_N=`expr $lt_dump_args_N + 1` - done -} - -# Core function for launching the target application -func_exec_program_core () -{ - - if test -n "$lt_option_debug"; then - $ECHO "tests:tests:$LINENO: newargv[0]: $progdir/$program" 1>&2 - func_lt_dump_args ${1+"$@"} 1>&2 - fi - exec "$progdir/$program" ${1+"$@"} - - $ECHO "$0: cannot exec $program $*" 1>&2 - exit 1 -} - -# A function to encapsulate launching the target application -# Strips options in the --lt-* namespace from $@ and -# launches target application with the remaining arguments. -func_exec_program () -{ - case " $* " in - *\ --lt-*) - for lt_wr_arg - do - case $lt_wr_arg in - --lt-*) ;; - *) set x "$@" "$lt_wr_arg"; shift;; - esac - shift - done ;; - esac - func_exec_program_core ${1+"$@"} -} - - # Parse options - func_parse_lt_options "$0" ${1+"$@"} - - # Find the directory that this script lives in. - thisdir=`$ECHO "$file" | /bin/sed 's%/[^/]*$%%'` - test "x$thisdir" = "x$file" && thisdir=. - - # Follow symbolic links until we get to the real thisdir. - file=`ls -ld "$file" | /bin/sed -n 's/.*-> //p'` - while test -n "$file"; do - destdir=`$ECHO "$file" | /bin/sed 's%/[^/]*$%%'` - - # If there was a directory component, then change thisdir. - if test "x$destdir" != "x$file"; then - case "$destdir" in - [\\/]* | [A-Za-z]:[\\/]*) thisdir="$destdir" ;; - *) thisdir="$thisdir/$destdir" ;; - esac - fi - - file=`$ECHO "$file" | /bin/sed 's%^.*/%%'` - file=`ls -ld "$thisdir/$file" | /bin/sed -n 's/.*-> //p'` - done - - # Usually 'no', except on cygwin/mingw when embedded into - # the cwrapper. - WRAPPER_SCRIPT_BELONGS_IN_OBJDIR=no - if test "$WRAPPER_SCRIPT_BELONGS_IN_OBJDIR" = "yes"; then - # special case for '.' - if test "$thisdir" = "."; then - thisdir=`pwd` - fi - # remove .libs from thisdir - case "$thisdir" in - *[\\/].libs ) thisdir=`$ECHO "$thisdir" | /bin/sed 's%[\\/][^\\/]*$%%'` ;; - .libs ) thisdir=. ;; - esac - fi - - # Try to get the absolute directory name. - absdir=`cd "$thisdir" && pwd` - test -n "$absdir" && thisdir="$absdir" - - program='tests' - progdir="$thisdir/.libs" - - - if test -f "$progdir/$program"; then - # Add our own library path to LD_LIBRARY_PATH - LD_LIBRARY_PATH="/sonic/src/sonic-sairedis/lib/.libs:/sonic/src/sonic-sairedis/meta/.libs:$LD_LIBRARY_PATH" - - # Some systems cannot cope with colon-terminated LD_LIBRARY_PATH - # The second colon is a workaround for a bug in BeOS R4 sed - LD_LIBRARY_PATH=`$ECHO "$LD_LIBRARY_PATH" | /bin/sed 's/::*$//'` - - export LD_LIBRARY_PATH - - if test "$libtool_execute_magic" != "%%%MAGIC variable%%%"; then - # Run the actual program with our arguments. - func_exec_program ${1+"$@"} - fi - else - # The program doesn't exist. - $ECHO "$0: error: '$progdir/$program' does not exist" 1>&2 - $ECHO "This script is just a wrapper for $program." 1>&2 - $ECHO "See the libtool documentation for more information." 1>&2 - exit 1 - fi -fi