fix and add unittests - draft

sonic-net · Dec 3, 2024 · 2f5bfe2 · 2f5bfe2
1 parent 51db5c1
commit 2f5bfe2
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 16 deletions.
diff --git a/proxylib/Sai.cpp b/proxylib/Sai.cpp
@@ -1129,11 +1129,11 @@ sai_status_t Sai::dbgGenerateDump(
         swss::FieldValueTuple("DBG_GENERATE_DUMP", dump_file_name),
     };
 
-    std::string key = "DBG_GEN_DUMP:01";
+    /*std::string key = "DBG_GEN_DUMP:01";
 
     m_communicationChannel->set(key, entry, "dbg_gen_dump");
 
-    /*swss::KeyOpFieldsValuesTuple kco;
+    swss::KeyOpFieldsValuesTuple kco;
 
     return m_communicationChannel->wait("dbg_gen_dumpresponse", kco);*/
 

diff --git a/unittest/lib/TestClientSai.cpp b/unittest/lib/TestClientSai.cpp
@@ -50,13 +50,3 @@ TEST(ClientSai, bulkGet)
                 statuses));
 }
 
-TEST(ClientSai, dbgGenerateDump)
-{
-    ClientSai sai;
-
-    sai.apiInitialize(0,&test_services);
-
-    const std::string filePath = "/var/log/dbgGenerateDump.log";
-
-    EXPECT_EQ(SAI_STATUS_NOT_IMPLEMENTED, sai.dbgGenerateDump(filePath.c_str()));
-}
diff --git a/unittest/lib/TestServerSai.cpp b/unittest/lib/TestServerSai.cpp
@@ -49,3 +49,4 @@ TEST(ServerSai, bulkGet)
                 SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR,
                 statuses));
 }
+
diff --git a/unittest/syncd/TestVendorSai.cpp b/unittest/syncd/TestVendorSai.cpp
@@ -1558,3 +1558,10 @@ TEST_F(VendorSaiTest, bulk_prefix_compression_entry)
     EXPECT_EQ(SAI_STATUS_NOT_SUPPORTED,
             m_vsai->bulkSet(0, e, nullptr, SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR, nullptr));
 }
+
+TEST_F(VendorSaiTest, dbgGenerateDump)
+{
+    const std::string filePath = "/var/log/testDump.log";
+
+    EXPECT_EQ(SAI_STATUS_SUCCESS, m_vsai->dbgGenerateDump(filePath.c_str()));
+}
diff --git a/unittest/vslib/TestSai.cpp b/unittest/vslib/TestSai.cpp
@@ -24,4 +24,13 @@ TEST(Sai, bulkGet)
                 attrs,
                 SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR,
                 statuses));
-}
+}
+
+TEST(Sai, dbgGenerateDump)
+{
+    Sai sai;
+
+    const std::string filePath = "/var/log/testDump.log";
+
+    EXPECT_EQ(SAI_STATUS_NOT_IMPLEMENTED, sai.dbgGenerateDump(filePath.c_str()));
+}
diff --git a/vslib/Sai.cpp b/vslib/Sai.cpp
@@ -856,11 +856,11 @@ sai_status_t Sai::queryApiVersion(
 sai_status_t Sai::dbgGenerateDump(
         _In_ const char *dump_file_name)
 {
-    MUTEX();
     SWSS_LOG_ENTER();
-    VS_CHECK_API_INITIALIZED();
 
-    return  m_meta->dbgGenerateDump(dump_file_name);
+    SWSS_LOG_ERROR("not implemented, FIXME");
+
+    return SAI_STATUS_NOT_IMPLEMENTED;
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -49,3 +49,4 @@ TEST(ServerSai, bulkGet)
		SAI_BULK_OP_ERROR_MODE_STOP_ON_ERROR,
		statuses));
		}