-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xcvrd] Skip to get dom/threshold/pm for flat memory #458
Conversation
@chiourung Can you fix the build failure |
@chiourung Please paste the output of "show transceiver eeprom" and "sfputil show eeprom -d -p" output for the CMIS and non-CMIS compliant output in the PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mihirpat1 can you review
Signed-off-by: chiourung_huang <[email protected]>
@@ -619,6 +631,9 @@ def post_port_dom_info_to_db(logical_port_name, port_mapping, table, stop_event= | |||
if not _wrapper_get_presence(physical_port): | |||
continue | |||
|
|||
if _wrapper_is_flat_memory(physical_port) == True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, no DOM (TRANSCEIVER_DOM_SENSOR) STATE_DB info is populated for xcvrs with flat memory?
Description
Fix sonic-net/sonic-buildimage#18468
xcvrd crashes due to PR sonic-net/sonic-platform-common#397.
Motivation and Context
How Has This Been Tested?
Insert CMIS DAC cable
QSFP DAC cable
QSFP AOC
CMIS ZR
Additional Information (Optional)