Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception occurred during decode vendor name and vendor pn #406

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix exception occurred during decode vendor name and vendor pn #406

merged 1 commit into from
Oct 11, 2023

Conversation

AnoopKamath
Copy link
Contributor

Description

Fix exception occurred during decode vendor name and vendor pn. This exception occurs for non CMIS modules. The vendor name and vendor pn are at different offsets.

Motivation and Context

fixes: sonic-net/sonic-buildimage#16838

How Has This Been Tested?

Additional Information (Optional)

@prgeor prgeor merged commit 76a8590 into sonic-net:master Oct 11, 2023
4 checks passed
@prgeor
Copy link
Collaborator

prgeor commented Oct 11, 2023

@StormLiangMS we need this fix in 202305

@mihirpat1
Copy link
Contributor

@StormLiangMS we need this fix in 202305

ADO - 25433849

@StormLiangMS
Copy link

@AnoopKamath could you test with 202305 image? And any dependency PR for this one?

@AnoopKamath
Copy link
Contributor Author

@AnoopKamath could you test with 202305 image? And any dependency PR for this one?

@StormLiangMS This PR will fix issue caused by PR #400.

jaganbal-a pushed a commit to jaganbal-a/for_PM_stats that referenced this pull request Oct 26, 2023
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Description
Update the code coverage rate to 80%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sonic-platform-common] Exception occurred while decoding cable vendor_pn and vendor_name
4 participants