Support reading/writing SFP module EEPROM by page and offset #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
force-pushed
the
master_rw_eeprom
branch
from
4ff3395 to
63d54da
Compare
mihirpat1
reviewed
Oct 19, 2023
|
Hi @mihirpat1 , thanks for all the comments, I have fixed them all, could you please help review again? |
mihirpat1
reviewed
Oct 19, 2023
mihirpat1
approved these changes
Oct 19, 2023
keboliu
previously approved these changes
Oct 23, 2023
prgeor
reviewed
Oct 24, 2023
|
Hi @prgeor , I have replied all comments, could you please help review again？ |
|
@Junchao-Mellanox we have scheduled a meeting to discuss further |
|
@Junchao-Mellanox do we need this PR ? |
Hi @prgeor , yes. |
Junchao-Mellanox
force-pushed
the
master_rw_eeprom
branch
from
6c8ca0e to
a0d4534
Compare
Junchao-Mellanox
force-pushed
the
master_rw_eeprom
branch
from
a0d4534 to
55e8d5d
Compare
|
No longer needed. Closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support reading/writing EEPROM by page and offset
Motivation and Context
HLD: sonic-net/SONiC#1475
How Has This Been Tested?
Unit test
Regression test
Additional Information (Optional)