Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor Monitor support #393

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Sensor Monitor support #393

merged 9 commits into from
Sep 7, 2023

Conversation

bmridul
Copy link
Collaborator

@bmridul bmridul commented Aug 10, 2023

Sonic Platform common changes required as part of Voltage & Current Sensor Monitoring Feature.

Description

New base class is introduced for defining voltage and current sensors.
Chassis and Module base classes are enhanced with APIs to retrieve voltage and current sensor data from platform.

Motivation and Context

The changes are required to support the design for sensor monitoring feature as proposed in the HLD.

HLD : sonic-net/SONiC#1394

How Has This Been Tested?

Tested with CLIs for sensor monitoring.

@bmridul bmridul changed the title Vsensor common Sensor Monitor support Aug 10, 2023
sonic_platform_base/module_base.py Outdated Show resolved Hide resolved
sonic_platform_base/sensor_base.py Outdated Show resolved Hide resolved
sonic_platform_base/sensor_base.py Outdated Show resolved Hide resolved
sonic_platform_base/sensor_base.py Outdated Show resolved Hide resolved
sonic_platform_base/sensor_base.py Outdated Show resolved Hide resolved
@abdosi abdosi merged commit 086a88c into sonic-net:master Sep 7, 2023
4 checks passed
@abdosi
Copy link
Contributor

abdosi commented Sep 7, 2023

@gechiang this is enhancement so will need to go to msft repo. not sure if we can take into 202205 branch.

@gechiang
Copy link

gechiang commented Sep 7, 2023

@gechiang this is enhancement so will need to go to msft repo. not sure if we can take into 202205 branch.

Unfortunately we currently do not have a separate MSFT Repo for sonic-platform-common so there is no way to take it in that way... either it is taken up in public 202205 or someone has to create the new MSFT repo for this submodule and also work with build team to enable auto sync works which was not that easy when we did it for sonic-utilities.msft So unless it is absolutely needed, no plan to create a new msft repo for new features.

@StormLiangMS
Copy link

new feature, no cherry pick.

oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Sensormond daemon is introduced. It collects the voltage and current sensor information from the platform and populates in the StateDB. The sensor data is available to view using CLIs. Sensormond raises syslogs when the sensors report measurement outside the thresholds.

sonic-net/SONiC#1394
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants