-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nokia][sonic-platform] Update Nokia sonic-platform submodule - SFP s… #16572
Conversation
…upport for CMIS CDB operations
@vmittal-msft and/or @prgeor, can you please review? Merging should be discussed in conjunction with release of NDK version >= 22.9.13 (as the two components must be coupled). |
@judyjoseph can you help review this? Will also tag you to review the new ndk 22.9.13 PR... |
@snider-nokia could you please share the logs in the PR description for the firmware download steps? |
@snider-nokia , Before this is picked into 202205 MSFT repo, the required NDK needs to be picked to 202205 MSFT repo first. Can you please create the needed PR for Azure/sonic-buildimage-msft#112 for 202205 MSFT branch? |
@gechiang Related NDK PR has been created: Azure/sonic-buildimage-msft#118 |
@lguohan , @yxieca , @StormLiangMS: |
@snider-nokia PR conflicts with 202211 branch |
…upport for CMIS CDB operations (sonic-net#16572) This fixes Nokia-ION/ndk#22 Note that this PR must be coupled with NDK version >= 22.9.13 Why I did it To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations). How I did it Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes). How to verify it Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
Cherry-pick PR to 202205: #16688 |
…upport for CMIS CDB operations (#16572) This fixes Nokia-ION/ndk#22 Note that this PR must be coupled with NDK version >= 22.9.13 Why I did it To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations). How I did it Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes). How to verify it Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
…upport for CMIS CDB operations (sonic-net#16572) This fixes Nokia-ION/ndk#22 Note that this PR must be coupled with NDK version >= 22.9.13 Why I did it To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations). How I did it Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes). How to verify it Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
Cherry-pick PR to 202305: #16796 |
@snider-nokia , do you intent to backport this to 202211 branch? If not, I will withdraw request for 202211 branch. |
This fixes https://github.com/Nokia-ION/ndk/issues/22
Note that this PR must be coupled with NDK version >= 22.9.13
Why I did it
To provide proper support for CMIS compliant transceiver module CDB operations (including FW related operations).
How I did it
Enhanced the transport subsystem so as to provide for up to 2k bytes of data to be passed to/from modules (as contrasted with the prior max of 128 bytes).
How to verify it
Ensure that new FW (firmware) can be programmed to CMIS compliant module(s) using the 'sfputil firmware ...' commands.
admin@ixre-egl-board29:~$ sudo sfputil firmware download Ethernet112 /tmp/560-0087-28_Rev_61.22.21_dp04qsdd_dp04sfp8.ackit
CDB: Starting firmware download
Downloading ... [###################################-] 99% 00:00:00
CDB: firmware download complete
Firmware download complete success
Total download Time: 0:03:53.455740
admin@ixre-egl-board29:~$ sudo sfputil firmware download Ethernet112 /tmp/560-0087-23_Rev_61.20.13_dp04qsdd_dp04sfp8.ackit
CDB: Starting firmware download
Downloading ... [###################################-] 99% 00:00:00
CDB: firmware download complete
Firmware download complete success
Total download Time: 0:03:51.552884
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Tested with branch 202205
Description for the changelog
Properly support CDB operations for CMIS transceiver modules
Note that this PR must be coupled with NDK version >= 22.9.13