Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-yang-models: WRED statistics yang #14758

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

rpmarvell
Copy link
Contributor

@rpmarvell rpmarvell commented Apr 20, 2023

Why I did it

Supporting WRED and ECN statistics in SONiC

Work item tracking
  • Microsoft ADO (number only):

How I did it

Added new flex counter groups in yang file

How to verify it

Compiled the sonic.bin and loaded the image to DUT with all the WRED feature changes.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

Description for the changelog

  • Yang changes for WRED_ECN_QUEUE and WRED_ECN_PORT flex counter groups

Link to config_db schema for YANG module changes

https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#flex_counter_table

Dependent Pull Requests:
Sonic-utilities pull request : sonic-net/sonic-utilities#2807
Sonic-sairedis pull request : sonic-net/sonic-sairedis#1234
Sonic-swss : pull request : sonic-net/sonic-swss#2750
Sonic-swss common pull request : sonic-net/sonic-swss-common#777

A picture of a cute animal (not mandatory but encouraged)

msosyak
msosyak previously approved these changes May 9, 2023
* Yang added for WRED_ECN_QUEUE flex counter group
* Yang added for WRED_ECN_PORT flex counter group

  Signed-off-by: [email protected]
@rpmarvell rpmarvell force-pushed the rpmarvell_wredstats_yang_changes branch from e3d296a to fbf3b46 Compare May 18, 2023 12:05
@rpmarvell rpmarvell requested a review from msosyak May 18, 2023 20:35
@stephenxs
Copy link
Collaborator

https://github.com/sonic-net/sonic-buildimage/blob/master/dockers/docker-orchagent/enable_counters.py#L41 should also be updated to support WRED counters.
This is to disable counter-polling for the fast reboot to accelerate the converging process.
The logic is

  1. counter polling is disabled by fast reboot script by writing the field into config_db.json directly
  2. once the system reboots from the fast reboot, enable_counters will be invoked to re-enable the counter-polling.

Without update the logic, the WRED counters will be disabled after fast reboot.

@rpmarvell
Copy link
Contributor Author

@stephenxs

https://github.com/sonic-net/sonic-buildimage/blob/master/dockers/docker-orchagent/enable_counters.py#L41 should also be updated to support WRED counters. This is to disable counter-polling for the fast reboot to accelerate the converging process. The logic is

  1. counter polling is disabled by fast reboot script by writing the field into config_db.json directly
  2. once the system reboots from the fast reboot, enable_counters will be invoked to re-enable the counter-polling.

Without update the logic, the WRED counters will be disabled after fast reboot.

====
WRED stats is not a default statistics. As far as i have verified using fast-reboot command, It retains the counterpoll status even after the fast-reboot is completed. It should be fine

@zhangyanzhao
Copy link
Collaborator

@lguohan @yxieca @kperumalbfn @donNewtonAlpha , @baxia-lan @Praveen-Brcm can anyone of you help to merge this PR? Thanks.

@yxieca yxieca merged commit ff4be8e into sonic-net:master Jun 14, 2023
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
* Yang added for WRED_ECN_QUEUE flex counter group
* Yang added for WRED_ECN_PORT flex counter group

  Signed-off-by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants