Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsai] Tidy up saiapi.cpp.j2 #646

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

jimmyzhai
Copy link
Collaborator

@jimmyzhai jimmyzhai commented Dec 5, 2024

Adjust the api locations, remove white spaces at the line end and remove blank lines, as to generate neat code.

Taking generated file SAI/lib/saidashoutboundrouting.cpp as an example, the side effect of this change is as below:

  • Remove the useless comment and align the statement
    image
  • Move bulk APIs (create|remove)_outbound_routing_entries after quad APIs (create|remove|set|get)_outbound_routing_group_attribute
    image

image

  • Remove white space between function name and '('
    image

@jimmyzhai jimmyzhai requested a review from r12f December 5, 2024 03:20
@r12f
Copy link
Collaborator

r12f commented Dec 5, 2024

hi Junhua, do you mind to help update the PR description to show the side effects of this change? it is not quite clear to me at this moment.

@jimmyzhai
Copy link
Collaborator Author

hi Junhua, do you mind to help update the PR description to show the side effects of this change? it is not quite clear to me at this moment.

Updated the description to list the side effects.

Copy link
Collaborator

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks Junhua!

@r12f r12f merged commit 69d76b5 into sonic-net:main Dec 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants