Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A potential bug that may mask the start and stop tokens #93

Open
lishen opened this issue Nov 10, 2020 · 1 comment
Open

A potential bug that may mask the start and stop tokens #93

lishen opened this issue Nov 10, 2020 · 1 comment
Labels
bug Something isn't working quick-fix This is an easy fix and should be done soon

Comments

@lishen
Copy link

lishen commented Nov 10, 2020

tape/tape/datasets.py

Line 351 in 3d3657b

pass

If I understand your code correctly, this line shall be continue instead of pass. If you use pass, the code will continue to mask the start and stop tokens with slightly less than 15% chance. I'm a bit surprised this hasn't caused any serious issues.
@rmrao
Copy link
Collaborator

rmrao commented Dec 17, 2020

Oh oops. Shouldn't really matter - predicting the start and stop tokens is easy enough for the model. I'll update the code when I get the chance.

@rmrao rmrao added bug Something isn't working quick-fix This is an easy fix and should be done soon labels Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working quick-fix This is an easy fix and should be done soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lishen @rmrao