Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'passive' option on event listeners #2210

Open
goswinr opened this issue Jul 4, 2024 · 0 comments
Open

Support 'passive' option on event listeners #2210

goswinr opened this issue Jul 4, 2024 · 0 comments

Comments

@goswinr
Copy link

goswinr commented Jul 4, 2024

Describe the bug

Most DOM events are not passive by default, but some are ( wheel, scroll, ..) .
see https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#passive
And it is not consistent among major Browsers.
Should Solids JSX support explicit passive options for event listeners ?
See how React addressed this issue: facebook/react#6436 and the resolution: facebook/react#19654
see example : https://playground.solidjs.com/anonymous/79b0f65b-ac15-486e-8fba-58eebe7048ba

import { render } from "solid-js/web";
import { onMount } from "solid-js";

function Counter() {  
  const wheel = (e:MouseEvent) => {
    e.preventDefault() // only works on not passive events
    e.stopPropagation()  
    console.log("wheel stopped?")
  }

  let div ;
  onMount(() => div.addEventListener("wheel", wheel, {passive:false}) ) // most events are not passive by default but "wheel" is in Chrome

  return (
    <>
    <div oncapture:wheel={wheel} style={{"background-color":"lightgreen","height":"26vh"}} />
    <div ref={div} style={{"background-color":"lightgray"  ,"height":"26vh"}} > In Chrome this gray div is the only div that prevents scrolling</div>
    <div on:wheel={wheel} style={{"background-color":"lightblue","height":"26vh"}} />
    <div onWheel={wheel} style={{"background-color":"crimson"  ,"height":"26vh"}} />
    </>
  );
}

render(() => <Counter />, document.getElementById("app")!);

Your Example Website or App

https://playground.solidjs.com/anonymous/79b0f65b-ac15-486e-8fba-58eebe7048ba

Steps to Reproduce the Bug or Issue

see https://playground.solidjs.com/anonymous/79b0f65b-ac15-486e-8fba-58eebe7048ba

Expected behavior

Like on:* and oncapture:*
There could be a JSX syntax to specify the passive option for events. Maybe onpassive:* and onnotpassive: * or onWheelNotPassive and onScrollNotPassive

Screenshots or Videos

No response

Platform

only in Chrome AFAIK

Additional context

No response

@goswinr goswinr changed the title Support Passive Event Listeners Support 'passive' option on event listeners Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant