-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crashes with a null cookie #11
Comments
This actually seems identical to #10. (Should have read more carefully) |
Some more info... I get the following response from the fetch inside
|
I've added some error-trapping for the login process - solid-contrib/solid-auth-fetcher#16 but since I've not seen anything like what you got above, I don't even know how to test for it. Is this coming from a specialized environment or straight from the command line? |
Yes, as mentioned above this is happening in an nwjs environment. However, I cannot identify anything environment specific that would prevent I have special characters in the password which like #10 might be tripping me up. But strangely it worked fine for me in a node environment ( :head-scratching: ) |
When I try to use solid-node-client in a nwjs environment, inside
SolidNodeClient.prototype._getAuthFetcher
, thecookie
is set tonull
and then the program crashes sincegetAuthFetcher()
expects a cookie to have length property. This might be a bug in solid-auth-fetcher and/or this call should exist in try catch block (in case authentication fails, though I am not sure why it would fail!).Strangely, it works fine when I run the same code in Node LTS! I am not sure what trips the code up, I would appreciate any suggestions where to look...
The text was updated successfully, but these errors were encountered: