commonAddedLinesContains

[steprescott]

I would like to check each line of any added or modified file to see if it contains a http:// url. However I can't seem to get anything to be flagged up as a warning. I'm currently on 1.22.1 as Peril isn't updated to danger 10.0.0 yet.

Although my regex isn't pro level I have checked using online testers. Is there anything below that you see I'm doing wrong?

import { commonAddedLinesContains } from 'danger-plugin-toolbox'

commonAddedLinesContains(/.*/, /http:\/\//i, file => `The file "${file}" contains insecure URL.`);

I've also checked to see if the job, due to it being async, needed to be scheduled.
Note that the messages are added to the PR

import { danger, schedule, message, warn } from 'danger';
import { commonAddedLinesContains } from 'danger-plugin-toolbox'

schedule(async () => {
  message('Before');
  await commonAddedLinesContains(/.*/, /http:\/\//i, file => `The file "${file}" contains insecure URL.`);
  message('After');
});

Thanks in advance.

[sogame]

Hi @steprescott,

It's really weird, I've just created this PR and it seems to be working fine: #272

Might it be related to Peril?
commonAddedLinesContains uses danger.git.diffForFile, and I've seen this issue: danger/peril#454

Could you do a couple of checks, please?

• Log the modified files, to make sure they're the expected ones: message(JSON.stringify(committedFilesGrep(/.*/)));
• Log the output of diffForFile for one of the modified files, to check if the output is the expected one or null like in the mentioned issue.

Thanks!

[sogame]

Oh, about using 1.22.1, I think you should be able to upgrade, danger is not a dependency of danger-plugin-toolbox, it's just installed to run danger in pr's (although upgrading won't fix this issue 😅)

[steprescott]

Thanks for the quick reply and sorry for my slow response. I'll log out what you suggested and then will post it back here. Thanks for the support. I'm glad the regex is working 😄

[sogame]

Hi @steprescott, any progress so far? 😇

[steprescott]

Sorry, I've been pulled in different directions so not getting a lot of time to look at this. Happy to close the ticket and reopen if it still occurs when I get back onto it.

[sogame]

Was more curiosity than concern about having the issue open 😂
Let me know any progress, happy to try to help if possible :-)