Avoid repeatedly evaluating the source if it's a complex expression

[adamw]

Closes #114

[adamw]

@KacperFKorban maybe you could take a look? :)

[KacperFKorban]

Ooo that's a really interesting bug. Though I'm glad I wasn't the one reading the generated code snippets 😅

I think that there's a more elegant solution for this. I'm pretty sure that simply removing inline here should fix the problem:

quicklens/quicklens/src/main/scala-3/com/softwaremill/quicklens/package.scala

Line 10 in 213a8e8

extension [S, A](inline obj: S)

[adamw]

@KacperFKorban Indeed! Nice :) I'm still stuck with Scala2-macro thinking ;) Seems to work - take another look then

[OndrejSpanel]

Why are those tests in scala-3 specific folder? Would they do any harm in shared? Esp. the functionality tests seems applicable for Scala 2 as well.

[KacperFKorban]

LGTM

[OndrejSpanel]

While the code currently does not compile, would it really be a bug if it did? It does compile in Scala 2. I think assertDoesNotCompile should not be used here.

[adamw]

it's in Scala3 sources as assertDoesNotCompile is a Scala3-only thing as far as I know (in ScalaTest).

As for this not compiling... I though that was the point showing the compiler timing issue (which is fixed here), but now I see there are two problems

[adamw]

I've extracted this as a separate issue, #116

[adamw]

And changed the type here to an unrelated one, which definitely shouldn't work :)