Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement code mappings #1756

Merged
merged 35 commits into from
Dec 4, 2024
Merged

Implement code mappings #1756

merged 35 commits into from
Dec 4, 2024
+264 −21

Conversation

DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Nov 20, 2024 •
edited
Loading

Closes #1647

@maciektr
Rework internal TokenStream representation (#1699)
d9c3ac5 
commit-id:ab3e2fd1

---

**Stack**:
- #1734
- #1722
- #1704
- #1700
- #1699 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Avoid unnecessary allocations when freeing stable structs (#1700)
1731b26 
commit-id:55ec12c0

---

**Stack**:
- #1734
- #1722
- #1704
- #1700 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Add cairo edition to TokenStreamMetadata (#1704)
23b6bfd 
commit-id:83c7db1f

---

**Stack**:
- #1734
- #1722
- #1704 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Allocate token's content into an arena (#1722)
8b8b19d 
commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@DelevoXDG DelevoXDG changed the base branch from main to dev November 20, 2024 14:46
@DelevoXDG DelevoXDG force-pushed the zdobnikau/1647-generate-code-mappings branch from 77b0a72 to e927659 Compare November 20, 2024 14:51
maciektr and others added 6 commits November 21, 2024 17:53
@maciektr
Implement Debug for InternedStr (#1760)
6cb1d27 
commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Refactor: split proc macro host into submodules (#1747)
17e15c2 
commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@DelevoXDG
Merge branch 'dev' into zdobnikau/1647-generate-code-mappings
86f5c5d
@DelevoXDG
Fix test, leave single attribute test
5c27985
@DelevoXDG
Add inline and derive macros tests
711b0a2 
Tests to be updated when #1647 is merged
@DelevoXDG
Format
9fd0bd6
@DelevoXDG DelevoXDG changed the title [WIP] Implement code mappings Implement code mappings Nov 25, 2024
@DelevoXDG DelevoXDG marked this pull request as ready for review November 25, 2024 12:08
@DelevoXDG DelevoXDG requested a review from a team as a code owner November 25, 2024 12:08
wawel37
wawel37 requested changes Nov 25, 2024
View reviewed changes
scarb/src/compiler/plugin/proc_macro/host/derive.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host/mod.rs Outdated Show resolved Hide resolved
scarb/src/compiler/plugin/proc_macro/host/derive.rs Outdated Show resolved Hide resolved
scarb/tests/build_cairo_plugin.rs Outdated Show resolved Hide resolved
scarb/tests/build_cairo_plugin.rs Show resolved Hide resolved
@maciektr
Rework internal TokenStream representation (#1699)
6b6c019 
commit-id:ab3e2fd1

---

**Stack**:
- #1734
- #1722
- #1704
- #1700
- #1699 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Avoid unnecessary allocations when freeing stable structs (#1700)
ba1fa1b 
commit-id:55ec12c0

---

**Stack**:
- #1734
- #1722
- #1704
- #1700 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Add cairo edition to TokenStreamMetadata (#1704)
4b42dba 
commit-id:83c7db1f

---

**Stack**:
- #1734
- #1722
- #1704 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Allocate token's content into an arena (#1722)
45c40ff 
commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Implement Debug for InternedStr (#1760)
ae6869e 
commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Refactor: split proc macro host into submodules (#1747)
ad94f7e 
commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@maciektr
Skip whitespace prefix when creating the span (#1761)
f5576c3 
commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@DelevoXDG DelevoXDG force-pushed the zdobnikau/1647-generate-code-mappings branch from 003210d to cb1de10 Compare November 26, 2024 18:32
maciektr
maciektr reviewed Dec 2, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
maciektr
maciektr approved these changes Dec 3, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@DelevoXDG DelevoXDG enabled auto-merge (squash) December 4, 2024 10:01
@DelevoXDG DelevoXDG merged commit 368d909 into dev Dec 4, 2024
22 checks passed
@DelevoXDG DelevoXDG deleted the zdobnikau/1647-generate-code-mappings branch December 4, 2024 10:50
maciektr added a commit that referenced this pull request Dec 4, 2024
@DelevoXDG @maciektr
Implement code mappings (#1756)
c2fad94 
Closes #1647

---------

Co-authored-by: maciektr <[email protected]>
maciektr added a commit that referenced this pull request Dec 4, 2024
@DelevoXDG @maciektr
Implement code mappings (#1756)
d54b90d 
Closes #1647

---------

Co-authored-by: maciektr <[email protected]>
maciektr added a commit that referenced this pull request Dec 4, 2024
@DelevoXDG @maciektr
Implement code mappings (#1756)
27d9756 
Closes #1647

---------

Co-authored-by: maciektr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

@wawel37 wawel37 wawel37 approved these changes

@Draggu Draggu Awaiting requested review from Draggu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create proper code mappings for procedural macro results
3 participants
@DelevoXDG @wawel37 @maciektr