Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 macOS (Apple Silicon) build #96

Open
fwcd opened this issue Sep 21, 2023 · 8 comments
Open

Add arm64 macOS (Apple Silicon) build #96

fwcd opened this issue Sep 21, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@fwcd
Copy link
Contributor

fwcd commented Sep 21, 2023

Warum ist der aktuelle Stand nicht akzeptabel?

The current macOS binaries produced by GitHub Releases don't run on ARM Macs as they bundle native x86_64 JavaFX libraries. Strangely running java under Rosetta doesn't work either, but since Java is largely cross-platform we should probably avoid emulation entirely.

Was wäre dein Lösungsansatz?

Provide a build for the macos-aarch64 (aka. osx-aarch64) platform as described in the upstream Gradle-JFX plugin.

While having GitHub-provisioned ARM runners would make this easy (since we could just add a new OS to the matrix), these aren't available yet. Still, making cross-builds should be doable since the JVM code is cross-platform anyway, so we would only have to ensure that Gradle bundles the native libraries for the specified target architecture. Still, that might require some fiddling, as evidenced by this thread:

@fwcd fwcd added the enhancement New feature or request label Sep 21, 2023
@xeruf xeruf added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 21, 2023
@xeruf xeruf removed their assignment Sep 21, 2023
@xeruf
Copy link
Member

xeruf commented Sep 21, 2023

open for contributions here, unless we get active complaints from schools I don't think I can make time for this anytime soon

@SKoschnicke
Copy link
Contributor

Apple Silicon GitHub runners are in public beta now. So this should be much easier. https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/

@fwcd
Copy link
Contributor Author

fwcd commented Oct 4, 2023

Yes, unfortunately they aren't free though...

@SKoschnicke
Copy link
Contributor

That shouldn't be a problem. @xeruf can you add a macOS runner for the build?

@xeruf
Copy link
Member

xeruf commented Oct 5, 2023

xlarge or large?

@xeruf
Copy link
Member

xeruf commented Oct 5, 2023

We need to cofngireu payment for that:

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

@SKoschnicke
Copy link
Contributor

That should be fixed. I guess "large"is sufficient.

@xeruf
Copy link
Member

xeruf commented Jun 28, 2024

It was implemented in d4f26f4 but I realized the releases never contained an arm image? Should check this since we pay for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants