Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma as a separation character messes with some localized float representation. #1050

Open
loothunter1 opened this issue Mar 10, 2022 · 1 comment
Labels
bug Doing something it's not meant to, or not doing something it's meant to.

Comments

@loothunter1
Copy link

On some localized systems (e.g. mine) floats have comma(,) separating integer part from the fraction part instead of dot(.). Because of that separating parameters in GetSettingsString/SetSettingsString in SfxrParams.cs with comma(,) creates a string that isn't read correctly. Please, change that symbol to something else.

I hope, my explanation was adequate, I have limited programming knowledge and English isn't my first language.

Thank you.

@loothunter1 loothunter1 added the bug Doing something it's not meant to, or not doing something it's meant to. label Mar 10, 2022
@stevehalliwell
Copy link
Collaborator

Sounds like something needs to be using InvariantCulture that isn't. If that is a string being manually editted by the user they need to be entered as InvariantCulture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doing something it's not meant to, or not doing something it's meant to.
Projects
None yet
Development

No branches or pull requests

2 participants