Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable bubbletea unit tests to run in github actions #169

Open
plastikfan opened this issue Feb 12, 2024 · 3 comments · Fixed by #170
Open

enable bubbletea unit tests to run in github actions #169

plastikfan opened this issue Feb 12, 2024 · 3 comments · Fixed by #170
Assignees
Labels
chore Non source related, infrasture change

Comments

@plastikfan
Copy link
Contributor

plastikfan commented Feb 12, 2024

To avoid the "could not open a new TTY" error when a tests runs in ci, the github actions config needs a change.

Issue might be related to gh-actions 241

@plastikfan plastikfan added the chore Non source related, infrasture change label Feb 12, 2024
@plastikfan plastikfan self-assigned this Feb 12, 2024
@plastikfan
Copy link
Contributor Author

As suggested by perplexity, I tried this in tthe workflow:

      - name: Set terminal environment
        run: export TERM=xterm

... and in context:

  golangci:
    name: lint
    runs-on: ubuntu-latest
    steps:
      - name: Set terminal environment
        run: export TERM=xterm

@plastikfan
Copy link
Contributor Author

plastikfan commented Feb 12, 2024

but actually, I might have made the change to the wrong job. Should be in test job, not golangci

This still fails even wehn moved to the test job.

Looking at bubbletea workflows, there is no mention of xterm.

Interesting article about the $TERM environment variable:

@plastikfan
Copy link
Contributor Author

The solution to this porblem has still not been found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Non source related, infrasture change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant