self-reply logic in Protocol.targets not consistently using domains for Web ids

[gerbenjacobs]

I'm using web -> fed.brid.gy and, while not documented on /docs I figured I would try to reply to my own note using u-in-reply-to microformat in order to thread my texts.

Unfortunately it didn't work, while it itself works as a webmention and even, to my surprise, works on Bluesky.

(Shortened) HTML for reply:

<article class="h-entry">
        <p>
            <small>In reply to: <a class="u-in-reply-to" href="https://gerben.dev/notes/2b7c13dd25a4c978e10267661216ae4b">
            https://gerben.dev/notes/2b7c13dd25a4c978e10267661216ae4b</a></small>
        </p>
        <div class="e-content">
            <p>I did however easily add Markdown support to my site.</p>
            <p>.. and this previous post helped me bug fix.</p>
        </div>
    <a class="u-bridgy-fed" href="https://fed.brid.gy/" hidden="hidden"></a>
</article>

On the fediverse it wasn't sent as a thread, it wasn't even sent as a regular post/note/text.

Bluesky thread: https://bsky.app/profile/gerben.dev.web.brid.gy/post/3ldc7v7uszri2
Original note: https://gerben.dev/notes/2b7c13dd25a4c978e10267661216ae4b (the webmention was manually sent)
Reply note: https://gerben.dev/replies/50be49821711d3d87c1d5f20e44aacb6

[snarfed]

Thanks for the detailed sleuthing and report! Looks like our self-reply logic for these situations is a bit flaky and got this wrong. Will fix.

For my own notes here, this is a domain vs homepage URL id mismatch on owner ids. Specifically, in Protocol.targets, owner here ended up as https://gerben.dev/:

bridgy-fed/protocol.py

Line 1328 in 604a7f6

owner = as1.get_owner(obj.as1)

...but as1.get_owner(orig_obj.as1) here was gerben.dev:

bridgy-fed/protocol.py

Line 1394 in 604a7f6

if id in in_reply_tos and owner == as1.get_owner(orig_obj.as1):