Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug generating Bluesky post facets when text includes [ ] brackets #1605

Open
snarfed opened this issue Dec 6, 2024 · 4 comments
Open

Bug generating Bluesky post facets when text includes [ ] brackets #1605

snarfed opened this issue Dec 6, 2024 · 4 comments
Labels
bug User-facing breakage and reliability issues within Bridgy Fed.

Comments

@snarfed snarfed added now bug User-facing breakage and reliability issues within Bridgy Fed. labels Dec 6, 2024
@Tamschi
Copy link
Collaborator

Tamschi commented Dec 6, 2024

That's two bugs in one. Any Markdown control characters need to be escaped (because otherwise it'll break for posts that contain e.g. [a](https://example.com/) as plain text), and it seems the Markdown-to-Bluesky conversion doesn't behave like most Markdown processors would.

Fortunately, it seems like fixing the first one would obscure the second.

@snarfed
Copy link
Owner Author

snarfed commented Dec 6, 2024

it seems the Markdown-to-Bluesky conversion doesn't behave like most Markdown processors would

Hmm! We don't currently expect or parse any external data as Markdown afaik, our use of Markdown is entirely a (small) internal implementation detail that shouldn't cause externally-visible bugs like this.

@Tamschi
Copy link
Collaborator

Tamschi commented Dec 9, 2024

it seems the Markdown-to-Bluesky conversion doesn't behave like most Markdown processors would

Hmm! We don't currently expect or parse any external data as Markdown afaik, our use of Markdown is entirely a (small) internal implementation detail that shouldn't cause externally-visible bugs like this.

No, Bridgy Fed does in fact parse all external content as Markdown right now since it doesn't escape Markdown control characters.
As I wrote, doing so will likely hide irregularities with the implementation though, as long as it handles those escape sequences well.

This is about the same issue as #1380 where no HTML escape is performed when converting to HTML for ActivityPub.

@snarfed
Copy link
Owner Author

snarfed commented Dec 9, 2024

Oh, I thought you meant deliberately parse Markdown, as in expect it anywhere inbound. Unintentionally, on the other hand, yes. 😁

@snarfed snarfed removed the now label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug User-facing breakage and reliability issues within Bridgy Fed.
Projects
None yet
Development

No branches or pull requests

2 participants