Into Bluesky: images should have aspectRatio, otherwise preview is square

[MS-potilas]

Related to bluesky-social/social-app#6474

If aspectRatio (width, height) is not set, images are previewed as clipped square. Examples here https://bsky.app/profile/fok-it.eliitin-some.fi.ap.brid.gy

Bluesky client app sets the aspectRatio, but most other clients (including blue deck) and API users don't (and now they're supposed to).

[snarfed]

Good point! Specifically, this is the aspectRatio field in app.bsky.embed.images.

Sadly, this is somewhat unlikely. I don't currently do any image processing at all, and I'm reluctant to start. I can keep this open to track though!

[ulrischa]

Same issue here https://bsky.app/profile/lfu.bayern.de

[snarfed]

@ulrischa looks like that's a normal Bluesky account, not a bridged account.

[ulrischa]

@snarfed yes it is. The problem has nothing to do with bridged or not. There seems to be a breaking change in aspect ratio handling. See bluesky-social/social-app#6800

[roddie-digital]

For info, Bluesky have implemented a (hopefully temporary) workaround for this in social-app#6828 - images are now displayed in their correct aspect ratio but within a square for their preview. eg:

https://bsky.app/profile/ghostintheshell.roddie.social/post/3lcjthp4mota2

[popet-master]

So eventually this issue, unrelated to bridgy, gets fixed by Bluesky, as a plain css bug on their side, right ?

[snarfed]

No, I don't think so. They now letterbox instead of cropping so that they don't cut anything out, but they still expect clients to all eventually set aspectRatio.

This isn't a high priority for Bridgy Fed right now, but PRs are welcome, feel free to try!

[Tamschi]

I think it's reasonable for them to do it this way with their architecture, as it decreases service dependencies significantly for them and enables fully asynchronous processing right up to and into the frontend. It's pretty elegant in a way.

[snarfed]

@JoelOtter is currently adding this to granary in snarfed/granary#844, that will do half of this and give us an easy template for the other half. Thank you Joel!

[MS-potilas]

Can the Granary addition be deployed "as is" to Bridgy Fed, too?

[snarfed]

As described in #1571 (comment), it's half of the solution! The other half is porting https://github.com/snarfed/granary/pull/844/files#diff-1915ad0740506cba5b100e33d222098b9ec534f9f592b600ab55571db03296b0L2175-R2288 to ATProto._convert in atproto.py here.