-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove writable-paths #74
base: main
Are you sure you want to change the base?
Remove writable-paths #74
Conversation
factory/usr/lib/systemd/system/initrd-core-system-defaults.service
Outdated
Show resolved
Hide resolved
811f98f
to
34e7f2a
Compare
c6c51ca
to
dbdf3be
Compare
As we hinted/discussed and after talking with @mvo5 again, given the timing, at this point this change should be scheduled for UC 24, to be done early in its development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach here has my +1 but I unfortunately won't have time to review the details
Instead we expect to load mounts from /etc/fstab from core. /sysroot /sysroot/writable are the only mountpoints that need to be mounted before /etc/fstab loaded, so only those mount units are left. The rest will be automatically loaded. Before loading /etc/fstab we need to prepare the writable disk. So before initrd-root-fs.target and after /sysroot/writable is mounted, we call systemd-tmpfiles for core-writable.conf. This commit requires change in core-base to provide /etc/fstab and core-writable.conf.
dbdf3be
to
aa0f1c4
Compare
And here we are in UC24. Can we do it? is it already done elsehow? |
we didn't do it early in the development, so not yet |
Instead we expect to load mounts from /etc/fstab from core.
/sysroot /sysroot/writable are the only mountpoints that need to be
mounted before /etc/fstab loaded, so only those mount units are left.
The rest will be automatically loaded.
Before loading /etc/fstab we need to prepare the writable disk. So
before initrd-root-fs.target and after /sysroot/writable is mounted,
we call systemd-tmpfiles for core-writable.conf.
This commit requires change in core-base to provide
/etc/fstab and core-writable.conf.
See canonical/core-base#25