Remove writable-paths #74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factory/usr/lib/systemd/system/initrd-core-system-defaults.service
Outdated
Show resolved
Hide resolved
valentindavid
force-pushed
the
valentindavid/remove-writable-paths
branch
from
811f98f
to
34e7f2a
Compare
valentindavid
force-pushed
the
valentindavid/remove-writable-paths
branch
3 times, most recently
from
c6c51ca
to
dbdf3be
Compare
|
As we hinted/discussed and after talking with @mvo5 again, given the timing, at this point this change should be scheduled for UC 24, to be done early in its development |
Instead we expect to load mounts from /etc/fstab from core. /sysroot /sysroot/writable are the only mountpoints that need to be mounted before /etc/fstab loaded, so only those mount units are left. The rest will be automatically loaded. Before loading /etc/fstab we need to prepare the writable disk. So before initrd-root-fs.target and after /sysroot/writable is mounted, we call systemd-tmpfiles for core-writable.conf. This commit requires change in core-base to provide /etc/fstab and core-writable.conf.
valentindavid
force-pushed
the
valentindavid/remove-writable-paths
branch
from
dbdf3be
to
aa0f1c4
Compare
|
And here we are in UC24. Can we do it? is it already done elsehow? |
we didn't do it early in the development, so not yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we expect to load mounts from /etc/fstab from core.
/sysroot /sysroot/writable are the only mountpoints that need to be
mounted before /etc/fstab loaded, so only those mount units are left.
The rest will be automatically loaded.
Before loading /etc/fstab we need to prepare the writable disk. So
before initrd-root-fs.target and after /sysroot/writable is mounted,
we call systemd-tmpfiles for core-writable.conf.
This commit requires change in core-base to provide
/etc/fstab and core-writable.conf.
See canonical/core-base#25