Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagonalisation problem in SMRT, active microwave mode #25

Closed
carlettif opened this issue Apr 11, 2024 · 2 comments
Closed

Diagonalisation problem in SMRT, active microwave mode #25

carlettif opened this issue Apr 11, 2024 · 2 comments

Comments

@carlettif
Copy link

carlettif commented Apr 11, 2024

Good morning everyone,

I write here because I have problems making use of the new DORT solver feature to ease diagonalisation problems in active microwave modelling with SMRT. In this doc https://github.com/smrt-model/smrt/blob/master/smrt/rtsolver/dort.py, I read: "Two new diagonalisation approches were added in Jan 2024. They are activated by setting the diagonalization_method optional argument (see :py:meth:smrt.core.make_model)". So, this is how I tried to make use of this new feature in my code:

model = make_model("symsce_torquato21", "dort", rtsolver_options=dict(error_handling="nan", diagonalization_method="shur_forcedtriu")) sensor = sensor_list.sentinel1(theta=constants["incidence_angle_theta"]) results = model.run(sensor, snowpacks, snowpack_dimension=("date", dates)) results_array = results.sigmaVV_dB()

However, I get the following error message:

TypeError: DORT.__init__() got an unexpected keyword argument 'diagonalization_method'

I've already made sure to pull all the new changes in SMRT code. I can build the model without problems, the warning comes when I run it. For sure I am doing something wrong. Could you help me solving this issue?

Thank you and have a good day,

Francesca Carletti

@ghislainp
Copy link
Member

ghislainp commented Apr 11, 2024

It is likely a SMRT version and installation issue. Can you check:

from smrt.rtsolver import dort
dort.DORT??

in ipython or in a notebook.

It should show the path to the dort.py file and the argument for the initialization. diagonalization_method must appear here. If not reinstall SMRT.

@carlettif
Copy link
Author

It worked, thank you very much for the fast reply!

Francesca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants