Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in Timer with large durations #86

Closed
notgull opened this issue Aug 19, 2022 · 1 comment · Fixed by #87
Closed

Fix panic in Timer with large durations #86

notgull opened this issue Aug 19, 2022 · 1 comment · Fixed by #87

Comments

@notgull
Copy link
Member

notgull commented Aug 19, 2022

See async-rs/async-std#1037. We should probably use checked_add when calculating the instant instead of regular addition.
@taiki-e
Copy link
Collaborator

taiki-e commented Aug 19, 2022 •
edited
Loading

"waiting indefinitely" or "waiting a few decades" are both reasonable solutions for such a case.

@notgull notgull mentioned this issue Aug 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve timer functionality bread-graphics/async-io
2 participants
@notgull @taiki-e