You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! After adding the support of ctrl-L keyboard shortcut, I've noticed the keyboard strokes are managed in a one big if...else, and that some of the keystrokes being handled are the same for both magictype and regulartype. ( Like ctrl-L :) )
I think it will be better to manage the keystrokes for both magictype and regulartype together, at least some of them to avoid code duplication. Also, both of them are getting the same parameters but text, which also cause a little bit of code duplication.
Any suggestions or disagreements will be happily received.
I hope it's ok 😟 It's my first time trying to help an open-source project :)
Thanks!
The text was updated successfully, but these errors were encountered:
Hi! After adding the support of ctrl-L keyboard shortcut, I've noticed the keyboard strokes are managed in a one big
if...else
, and that some of the keystrokes being handled are the same for bothmagictype
andregulartype
. ( Like ctrl-L :) )I think it will be better to manage the keystrokes for both
magictype
andregulartype
together, at least some of them to avoid code duplication. Also, both of them are getting the same parameters buttext
, which also cause a little bit of code duplication.Any suggestions or disagreements will be happily received.
I hope it's ok 😟 It's my first time trying to help an open-source project :)
Thanks!
The text was updated successfully, but these errors were encountered: