Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept non promise ? #5

Open
raskyer opened this issue Mar 29, 2023 · 2 comments
Open

Accept non promise ? #5

raskyer opened this issue Mar 29, 2023 · 2 comments

Comments

@raskyer
Copy link
Contributor

raskyer commented Mar 29, 2023

Promise.all accept non promise in its array, whereas combinePromises need a Promise in order to not complain.
An easy workaround is to put Promise.resolve but it would be even better to be able to pass raw data directly as for Promise.all
@raskyer
Copy link
Contributor Author

raskyer commented Jul 14, 2023

Is it a dead project @slorber ?

@slorber
Copy link
Owner

slorber commented Jul 27, 2023

@raskyer that looks reasonable, if you submit a PR I'll merge it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slorber @raskyer