Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

led_vu_config enhancements #320

Open
NenuSB opened this issue Sep 30, 2023 · 6 comments
Open

led_vu_config enhancements #320

NenuSB opened this issue Sep 30, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@NenuSB
Copy link

NenuSB commented Sep 30, 2023

Suggestions for improvement in the VU meters with addressable leds:

add an LED gain setting in the ESP32 settings in LMS:
* I never have a player even close to 100% volume, usually~50%, but would like to see more then half of the leds do something.
* adding extra dummy leds won't work, because the center for L/R would shift
it doesn't seem to work if no DAC is configured. That's fine, I guess, but would be good to mention in the readme?

I am new to Github; so please tell me if I am doing something wrong with these submissions and/or if I shouldn't even be making them.

@sle118 sle118 added the enhancement New feature or request label Sep 30, 2023
@sle118
Copy link
Owner

sle118 commented Sep 30, 2023

I suggest @wizmo2 have a look at this

@wizmo2
Copy link

wizmo2 commented Sep 30, 2023

add an LED gain setting in the ESP32 settings in LMS

I'll look into it.

it doesn't seem to work if no DAC is configured

What do you use as audio out?

@NenuSB
Copy link
Author

NenuSB commented Sep 30, 2023

What do you use as audio out?

Nothing. Suppose you want to use it purely as a VU meter, synched to some other squeezeboxes. But I don't think that's much of a use case, and I can always add a dummy entry anyway.
So I don't think that is worth fixing, but maybe a mention in the readme.

@sle118
Copy link
Owner

sle118 commented Oct 1, 2023

the default output is i2S and since the data is one way out from the ESP32, there's no need for an actual DAC to be connected. Now this use case is yet another creative way to use our project!

@NenuSB
Copy link
Author

NenuSB commented Oct 1, 2023

there's no need for an actual DAC to be connected.

But it is still necessary to define one in the settings, I found.
I entered something like "dac_config: model=I2S,bck=12,ws=32,do=33" without physically connecting anything.
If you just want to use it for the VU, you should have plenty of spare GPIOs anyway, I guess.

@sle118
Copy link
Owner

sle118 commented Oct 3, 2023

@NenuSB yes. To me this is a "hacky" way to use the firmware, since this wasn't one of the use cases we had in mind. I'm glad if it works for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants