Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating AxiStreamRingBuffer.vhd #1116

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Updating AxiStreamRingBuffer.vhd #1116

merged 1 commit into from
Sep 27, 2023

Conversation

ruck314
Copy link
Contributor

@ruck314 ruck314 commented Sep 27, 2023

Description

  • adding support for COMMON_CLK_G when (dataClk=axilClk) case

@ruck314
Updating AxiStreamRingBuffer.vhd
f85aebb 
adding support for COMMON_CLK_G when (dataClk=axilClk) case
@ruck314 ruck314 requested a review from jumdz September 27, 2023 17:15
@ruck314 ruck314 mentioned this pull request Sep 27, 2023
Merged
@jumdz
Copy link
Contributor

jumdz commented Sep 27, 2023

Sounds good to me but, couldn't it be even improve by disabling the synchronizer fifos when the COMMON_CLK_G is set to true ?

@ruck314
Copy link
Contributor Author

ruck314 commented Sep 27, 2023

@jumdz Required if we want to build with URAM (single clock domain RAM) for the ring buffer memory

@ruck314 ruck314 merged commit 371ed89 into pre-release Sep 27, 2023
3 checks passed
@ruck314 ruck314 deleted the AxiStreamRingBuffer-update branch September 27, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jumdz jumdz jumdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruck314 @jumdz