Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby version for documentation generation (2.7.6 is end-of-life) #2129

Open
filmaj opened this issue Jun 7, 2024 · 2 comments
Open
Labels
auto-triage-skip Prevent this issue from being closed due to lack of activity dependencies Pull requests that update a dependency file docs M-T: Documentation work only enhancement M-T: A feature request for new functionality good first issue Good for newcomers semver:patch

Comments

@filmaj
Copy link
Contributor

filmaj commented Jun 7, 2024

If you go to build the documentation locally, following the directions in the maintainer's guide (.github/maintainers_guide.md), you will see warnings in your console like so:

➜ bundle install
rbenv: version `2.7.6' is not installed

➜ rbenv install 2.7.6
To follow progress, use 'tail -f /var/folders/k0/mp_cy45d7h7btpfxd62q16dc0000gq/T/ruby-build.20240607085431.58478.log' or pass --verbose
Downloading openssl-1.1.1w.tar.gz...
-> https://dqw8nmjcqpjn7.cloudfront.net/cf3098950cb4d853ad95c0841f1f9c6d3dc102dccfcacd521d93925208b76ac8
Installing openssl-1.1.1w...
Installed openssl-1.1.1w to /Users/fmaj/.rbenv/versions/2.7.6

Downloading ruby-2.7.6.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.6.tar.bz2
Installing ruby-2.7.6...

WARNING: ruby-2.7.6 is nearing its end of life.
It only receives critical security updates, no bug fixes.


WARNING: ruby-2.7.6 is past its end of life and is now unsupported.
It no longer receives bug fixes or critical security updates.

Perhaps it is as simple as updating the ruby version in the docs/.ruby-version file, but haven't tried myself. We should fix this!

@filmaj filmaj added enhancement M-T: A feature request for new functionality docs M-T: Documentation work only good first issue Good for newcomers semver:patch dependencies Pull requests that update a dependency file labels Jun 7, 2024
@zimeg
Copy link
Member

zimeg commented Jun 7, 2024

This EOL has bugged me but we might be fixed to 2.7.x by github pages. It's unclear to me if this dependency actually needs to be fixed or set though 🤔

That page links to a few other resources that don't mention a fixed Ruby v2, so maybe bumping to the latest is alright? Here are some of those interesting links:

The Github actions page is interesting since a migration is happening that requires pages be built in actions, but we're already doing that here so it might be no worry:

All GitHub Pages builds will use GitHub Actions from June 30, 2024.

Just sharing thoughts and info since I haven't tried upgrading this either 😅

Copy link

github-actions bot commented Jul 8, 2024

👋 It looks like this issue has been open for 30 days with no activity. We'll mark this as stale for now, and wait 10 days for an update or for further comment before closing this issue out. If you think this issue needs to be prioritized, please comment to get the thread going again! Maintainers also review issues marked as stale on a regular basis and comment or adjust status if the issue needs to be reprioritized.

@filmaj filmaj added auto-triage-skip Prevent this issue from being closed due to lack of activity and removed auto-triage-stale labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-triage-skip Prevent this issue from being closed due to lack of activity dependencies Pull requests that update a dependency file docs M-T: Documentation work only enhancement M-T: A feature request for new functionality good first issue Good for newcomers semver:patch
Projects
None yet
Development

No branches or pull requests

2 participants