Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add the pilot id to the profile page #2265

Open
vicb opened this issue Oct 28, 2020 · 7 comments
Open

[Feature] Add the pilot id to the profile page #2265

vicb opened this issue Oct 28, 2020 · 7 comments

Comments

@vicb
Copy link
Contributor

vicb commented Oct 28, 2020

Pilots need to enter their Skylines (numerical) id in flyxc.app if they want to appear on the map.

Currently there is no "easy" way to get the numerical id.

The only way is to navigate to your user page and get the id from the last segment of the url, i.e. https://skylines.aero/users/4758.

This is not super convenient for pilots that are not tech savvy - and some browsers hides the address bar by default.

Would it be possible to add a row with the id on the profile page (https://skylines.aero/settings/profile) ?
It's much easier to direct people there to lookup there id.

Thanks.

@Turbo87
Copy link
Member

Turbo87 commented Oct 29, 2020

Pilots need to enter their Skylines (numerical) id in flyxc.app if they want to appear on the map.

that seems like a limitation in flyxc.app to me. why does that app need the user id?

@vicb
Copy link
Contributor Author

vicb commented Oct 29, 2020

that seems like a limitation in flyxc.app to me. why does that app need the user id?

How else would I retrieve the pilot's positions from flyxc.app ? i.e. the API takes pilot ids (live/id/json).

It could be helpful for other app too, i.e. FlySkyHigh can send postions to the SkyLines server but there is no way to display pilots flying around you on the map which is supported only for LiveTrack24 pilots.

@vicb
Copy link
Contributor Author

vicb commented Nov 23, 2020

Hey @Turbo87,

I think the id would be best added to the Live Tracking section, i.e. https://skylines.aero/settings/tracking

I'd like to get a stab a this if you don't mind and would be open to merge it.

I think need to do something similar to the tracking key. The id would be to add a panel below the tracking key with the tracking id.

A few questions:

  1. Do you know if there is a Docker file that can be used to bootstrap a SkyLines server ?
  2. Do you have any pointer on how to pass data to the hbs. I believe this is Ember ? A pointer to a good tutorial would help.

Thanks !

@Turbo87
Copy link
Member

Turbo87 commented Nov 23, 2020

the ID is quite unrelated to the tracking though, it only seems related because apparently your app is using it for live tracking. I'm not sure if we should really make this ID such a publicly visible thing. yes, it is currently part of the URLs, but only because there is nothing else unique that we could use.

why don't you use the search API to find the right users and then add them through that?

@vicb
Copy link
Contributor Author

vicb commented Nov 23, 2020

The ID is quite unrelated to the tracking though

From the user point of view it is related.

They would use their ID to display their live tracks / positions on other live tracking apps.
The wouldn't have take care about their ID if they do not want to do that.

That's why I thought it could go in the Live Tracking section.

why don't you use the search API to find the right users and then add them through that?

That could actually be an idea.

Users are used to have something unique that identify them, like a username, a password, a key, ...

Do you think it would be possible to support searching by email in the search API ?

I think the best for users would actually to be able to search by live tracking key.
Then apps would only have to only for the tracking key whether they want to publish or retrieve live tracks.

What do you think ?

@Turbo87
Copy link
Member

Turbo87 commented Nov 23, 2020

Do you think it would be possible to support searching by email in the search API ?

no, because emails are private information that is not shared with others.

I think the best for users would actually to be able to search by live tracking key.

same thing, the live tracking key is private information that should not be shared with anyone as it allows write access for the account

@vicb
Copy link
Contributor Author

vicb commented Nov 23, 2020

same thing, the live tracking key is private information that should not be shared with anyone as it allows write access for the account

It would be up to the user to share their tracking key.
The search API should only be able to retrieve by tracking, it would not publish the tracking key.
That would be not much different at what exists today: users already share their API key if they want to be tracked (i.e. in Skylines, FlySkyHigh, ...).

What do you think ?

@vicb vicb closed this as completed Nov 24, 2020
@vicb vicb reopened this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants