Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all SnapshotTestOptions configurable via DSL #94

Open
skuzzle opened this issue Mar 30, 2023 · 0 comments
Open

Make all SnapshotTestOptions configurable via DSL #94

skuzzle opened this issue Mar 30, 2023 · 0 comments
Labels
component: core enhancement New feature or request

Comments

@skuzzle
Copy link
Owner

skuzzle commented Mar 30, 2023

We should enhance the DSL so that all the options that can be configured via @SnapshotTestOptions can also be configured via the DSL like

@Test
void someTest(Snapshot snapshot) {
    snapshot.withOptions(options -> options
        .withtextDiffContextLines(10)
        .withalwaysPersistActualResult(true))
    ...
}

This solution is kind of in conflict with the current SnapshotConfiguration class approach which serves partly the same use case but isn't configurable from public API.

Solving this might require deeper refactorings in the core module

@skuzzle skuzzle added enhancement New feature or request component: core labels Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant