Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null values in API crash the device #565

Open
w3irdrobot opened this issue Dec 8, 2024 · 0 comments
Open

null values in API crash the device #565

w3irdrobot opened this issue Dec 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@w3irdrobot
Copy link

w3irdrobot commented Dec 8, 2024

Note: Issues are not for customer support, configuration or discussion. For those topics please consult with your HW vendor or the OSMU Discord at: https://osmu.bitaxe.org

Describe the bug

When updating settings through the API at PATCH /api/system, if any values are explicitly null, it seems to crash the entire device.

To Reproduce
Steps to reproduce the behavior:

  1. Have a Bitaxe.
  2. Dance because you own a Bitaxe, and that's awesome.
  3. Get device IP
  4. Run the command curl -v -X PATCH -d '{"wifiPass":null}' http://<DEVICE_IP>/api/system
  5. Notice that the device restarts itself (fans spin down, Uptime in web app resets)
  6. Cry

Expected behavior

I would expect it to be ignored or an error be thrown to let me know I screwed up the request body.

Screenshots & Photos
If applicable, add AxeOS screenshots and/or photos of your Bitaxe to help explain your problem.

Hardware (please complete the following information):

  • Bitaxe HW version: Gamma 601
  • Bitaxe HW vendor: Solo Satoshi
  • ESP-Miner FW version: v2.4.0
  • Hash Frequency: 525
  • Voltage: 1150
  • Pool URL, Port, User: Braiins.....

Additional context

I checked all the settings and it appeared these ones being set to null are when the issues turn up. The others seem to just treat it as false.

hostname
ssid
wifiPass
stratumURL
stratumUser
stratumPassword
fallbackStratumURL
fallbackStratumUser
fallbackStratumPassword
@WantClue WantClue added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants