-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Function Comments in classes and Methods #27
Comments
Hello @kezenwa Thanks! Sounds like a good idea, I will definitely consider adding this information to the source code. However currently I have to solve some problems before Bypass and ZeroSSL are usable, see #26 (comment) |
Observation #2 : USE of same KEY both for ACCOUNT Key (account_key) and PRIVATE KeyNoticed this script uses same key both for LetsEncrypt account and for Certificate Private key which I believe isn't really cool from a security point. On a lighter note, the script creates a FullChain certificate but we sometimes equally need a Chain Certificate and a Cert e.g Thanks |
Observation #3 : Please make all
|
Observation 2 is not true, ACMECert does not use the same key for account key and for the private key for the certificate: You have to pass the account key to the loadAccountKey function. And the private key for the certificate to the getCertificateChain function. If accidentally the same key is used in both places Let's Encrypt does not allow it. You get the following error in this case: ACME_Exception: Error finalizing order :: certificate public key must be different than account key (urn:ietf:params:acme:error:malformed) in ACMECert.php also see: https://community.letsencrypt.org/t/use-existing-private-key-as-an-account-key/35766/3
This should not be difficult to implement (The first certificate in the fullchain is the main certificate and the rest is the chain). I'll add a function for this. |
Observation 3: sounds reasonable! I'll probably to change this in the next release. |
Just seeing this BUT I have done the Modifications already. Am kinda new to most things Certificates hence didn't understand a lot BUT after hours of going through different source codes + few Googlings, was able to observe that which I have done. Reason why I needed those 2 anyways was to be able to submit certificates to SCT logs. Thanks for your response and time |
Hello
Really love your work especially with this multi Ca feature (i.e ability to use the class not for just LetsEncrypt alone but also ZeroSsl and BuyPass).
In the comments you promised to merge this branch with Master. May I make a suggestion ?
Observation #1 : No Function Comments in classes and Methods
I noticed none of the class methods and function have comments / comment headers e.g
ought to look this way
Would have made the changes myself BUT don't know Git much. Guess when I have more time, would try knowing some GIT.
I understand these information already are on the index page but we need not always consult that page to get more information on what a class method does.
Once again, Really appreciate the work.
Thanks
The text was updated successfully, but these errors were encountered: