Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for go1.16 #28

Open
sivan-koren opened this issue Feb 19, 2021 · 4 comments
Open

update for go1.16 #28

sivan-koren opened this issue Feb 19, 2021 · 4 comments

Comments

@sivan-koren
Copy link

This is a really great project. Thank you for this!

With go1.16 old style modules are being deprecated (to be removed completely in 1.17 according to the blog).

From the instructions, "go generate" will not work because github.com/skilld-labs/go-odoo will not exist.

The instructions should be updated to reflect that.

Great work!

@ahuret
Copy link
Collaborator

ahuret commented Feb 19, 2021

Hi @sivan-koren !

First, thanks a lot for using this projet and for giving feedbacks ! :D

With go1.16 old style modules are being deprecated

I'm not sure to understand what you mean by "old style modules", are you about GOPATH ?

I think go-odoo need some love to redesign the way to generate models.
Actually, as is, the generator + README's instructions works only with GOPATH enable.

If you have any idea, please share :-) I'll think about it soon (after my vacations next week), and I'll propose some rework !

@ahuret
Copy link
Collaborator

ahuret commented Feb 19, 2021

I've updated README to prevent about GOPATH usage:
see e9a6cf6

@sivan-koren
Copy link
Author

Yes, that is what I meant.

As of yesterday, updating to 1.16 requires:
"go env -w GO111MODULE=off" and only then run "go get."

@ahuret
Copy link
Collaborator

ahuret commented Aug 19, 2022

related #32 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants