From efc67fd7e8818af6dad291d88c9f999eb3ff82d7 Mon Sep 17 00:00:00 2001
From: sk <sk22@mailbox.org>
Date: Fri, 6 Oct 2023 17:26:59 +0200
Subject: [PATCH] remove inset poll styles

closes sk22#801
---
 .../PollOptionStatusDisplayItem.java          | 16 ++++---------
 .../res/color/poll_option_progress_inset.xml  |  5 ----
 .../main/res/color/poll_option_text_inset.xml |  5 ----
 .../bg_poll_option_clickable_inset.xml        | 16 -------------
 .../drawable/bg_poll_option_voted_inset.xml   | 23 -------------------
 5 files changed, 5 insertions(+), 60 deletions(-)
 delete mode 100644 mastodon/src/main/res/color/poll_option_progress_inset.xml
 delete mode 100644 mastodon/src/main/res/color/poll_option_text_inset.xml
 delete mode 100644 mastodon/src/main/res/drawable/bg_poll_option_clickable_inset.xml
 delete mode 100644 mastodon/src/main/res/drawable/bg_poll_option_voted_inset.xml

diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/PollOptionStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/PollOptionStatusDisplayItem.java
index ee3357e666..a1eae6f995 100644
--- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/PollOptionStatusDisplayItem.java
+++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/PollOptionStatusDisplayItem.java
@@ -68,7 +68,7 @@ public static class Holder extends StatusDisplayItem.Holder<PollOptionStatusDisp
 		private final TextView text, percent;
 		private final View button;
 		private final ImageView icon;
-		private final Drawable progressBg, progressBgInset;
+		private final Drawable progressBg;
 
 		public Holder(Activity activity, ViewGroup parent){
 			super(activity, R.layout.display_item_poll_option, parent);
@@ -77,7 +77,6 @@ public Holder(Activity activity, ViewGroup parent){
 			icon=findViewById(R.id.icon);
 			button=findViewById(R.id.button);
 			progressBg=activity.getResources().getDrawable(R.drawable.bg_poll_option_voted, activity.getTheme()).mutate();
-			progressBgInset=activity.getResources().getDrawable(R.drawable.bg_poll_option_voted_inset, activity.getTheme()).mutate();
 			itemView.setOnClickListener(this::onButtonClick);
 			button.setOutlineProvider(OutlineProviders.roundedRect(20));
 			button.setClipToOutline(true);
@@ -93,22 +92,17 @@ public void onBind(PollOptionStatusDisplayItem item){
 					item.showResults ? R.drawable.ic_poll_option_button : R.drawable.ic_fluent_radio_button_24_selector
 			));
 			if(item.showResults){
-				Drawable bg=item.inset ? progressBgInset : progressBg;
+				Drawable bg=progressBg;
 				bg.setLevel(Math.round(10000f*item.votesFraction));
 				button.setBackground(bg);
 				itemView.setSelected(item.poll.ownVotes!=null && item.poll.ownVotes.contains(item.optionIndex));
 				percent.setText(String.format(Locale.getDefault(), "%d%%", Math.round(item.votesFraction*100f)));
 			}else{
 				itemView.setSelected(item.poll.selectedOptions!=null && item.poll.selectedOptions.contains(item.option));
-				button.setBackgroundResource(item.inset ? R.drawable.bg_poll_option_clickable_inset : R.drawable.bg_poll_option_clickable);
-			}
-			if(item.inset){
-				text.setTextColor(itemView.getContext().getColorStateList(R.color.poll_option_text_inset));
-				percent.setTextColor(itemView.getContext().getColorStateList(R.color.poll_option_text_inset));
-			}else{
-				text.setTextColor(UiUtils.getThemeColor(itemView.getContext(), android.R.attr.textColorPrimary));
-				percent.setTextColor(UiUtils.getThemeColor(itemView.getContext(), R.attr.colorM3OnSecondaryContainer));
+				button.setBackgroundResource(R.drawable.bg_poll_option_clickable);
 			}
+			text.setTextColor(UiUtils.getThemeColor(itemView.getContext(), android.R.attr.textColorPrimary));
+			percent.setTextColor(UiUtils.getThemeColor(itemView.getContext(), R.attr.colorM3OnSecondaryContainer));
 		}
 
 		@Override
diff --git a/mastodon/src/main/res/color/poll_option_progress_inset.xml b/mastodon/src/main/res/color/poll_option_progress_inset.xml
deleted file mode 100644
index 3fd78b91e3..0000000000
--- a/mastodon/src/main/res/color/poll_option_progress_inset.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:color="?colorM3TertiaryContainer" android:state_selected="true"/>
-	<item android:color="?colorM3SurfaceVariant"/>
-</selector>
\ No newline at end of file
diff --git a/mastodon/src/main/res/color/poll_option_text_inset.xml b/mastodon/src/main/res/color/poll_option_text_inset.xml
deleted file mode 100644
index ef1f151e6f..0000000000
--- a/mastodon/src/main/res/color/poll_option_text_inset.xml
+++ /dev/null
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-	<item android:color="?colorM3OnTertiaryContainer" android:state_selected="true"/>
-	<item android:color="?colorM3OnSurface"/>
-</selector>
\ No newline at end of file
diff --git a/mastodon/src/main/res/drawable/bg_poll_option_clickable_inset.xml b/mastodon/src/main/res/drawable/bg_poll_option_clickable_inset.xml
deleted file mode 100644
index 29dd2b1fc1..0000000000
--- a/mastodon/src/main/res/drawable/bg_poll_option_clickable_inset.xml
+++ /dev/null
@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<ripple xmlns:android="http://schemas.android.com/apk/res/android" android:color="?android:colorControlHighlight">
-	<item>
-		<shape>
-			<stroke android:width="1dp" android:color="?colorM3Outline"/>
-			<solid android:color="?colorM3Surface"/>
-			<corners android:radius="20dp"/>
-		</shape>
-	</item>
-	<item android:id="@android:id/mask">
-		<shape>
-			<solid android:color="#000"/>
-			<corners android:radius="20dp"/>
-		</shape>
-	</item>
-</ripple>
\ No newline at end of file
diff --git a/mastodon/src/main/res/drawable/bg_poll_option_voted_inset.xml b/mastodon/src/main/res/drawable/bg_poll_option_voted_inset.xml
deleted file mode 100644
index 1bc8c099bb..0000000000
--- a/mastodon/src/main/res/drawable/bg_poll_option_voted_inset.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<layer-list xmlns:android="http://schemas.android.com/apk/res/android">
-	<item>
-		<shape>
-			<solid android:color="?colorM3Surface"/>
-			<corners android:radius="20dp"/>
-		</shape>
-	</item>
-	<item>
-		<scale android:scaleGravity="start|fill_vertical" android:scaleWidth="100%">
-			<shape>
-				<solid android:color="@color/poll_option_progress_inset"/>
-				<corners android:radius="20dp"/>
-			</shape>
-		</scale>
-	</item>
-	<item>
-		<shape>
-			<stroke android:width="1dp" android:color="?colorM3Outline"/>
-			<corners android:radius="20dp"/>
-		</shape>
-	</item>
-</layer-list>
\ No newline at end of file