From a7941310bc2123d4ae5a979738e6661946899c37 Mon Sep 17 00:00:00 2001 From: sk Date: Sun, 15 Oct 2023 20:11:03 +0200 Subject: [PATCH] no more vertical reblog/reply line layout closes sk22#834 --- .../ReblogOrReplyLineStatusDisplayItem.java | 21 ------------------- .../display_item_reblog_or_reply_line.xml | 4 ++-- 2 files changed, 2 insertions(+), 23 deletions(-) diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java index d6488b48e5..a8d7f05542 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java @@ -111,9 +111,6 @@ public Holder(Activity activity, ViewGroup parent){ text=findViewById(R.id.text); extraText=findViewById(R.id.extra_text); separator=findViewById(R.id.separator); - parent.addOnLayoutChangeListener((v, l, t, right, b, ol, ot, oldRight, ob) -> { - if (right != oldRight) layoutLine(); - }); } private void bindLine(ReblogOrReplyLineStatusDisplayItem item, TextView text) { @@ -144,24 +141,6 @@ public void onBind(ReblogOrReplyLineStatusDisplayItem item){ extraText.setVisibility(item.extra == null ? View.GONE : View.VISIBLE); separator.setVisibility(item.extra == null ? View.GONE : View.VISIBLE); itemView.setPadding(itemView.getPaddingLeft(), itemView.getPaddingTop(), itemView.getPaddingRight(), item.needBottomPadding ? V.dp(16) : 0); - layoutLine(); - } - - private void layoutLine() { - if(item.extra==null) return; - itemView.measure( - View.MeasureSpec.makeMeasureSpec(parent.getWidth(), View.MeasureSpec.EXACTLY), - View.MeasureSpec.UNSPECIFIED); - boolean isVertical = ((LinearLayout) itemView).getOrientation() == LinearLayout.VERTICAL; - extraText.setPaddingRelative(extraText.getPaddingStart(), item.extra != null && isVertical ? 0 : V.dp(16), extraText.getPaddingEnd(), extraText.getPaddingBottom()); - separator.setVisibility(item.extra != null && !isVertical ? View.VISIBLE : View.GONE); - ((LinearLayout) itemView).removeView(extraText); - if (isVertical) ((LinearLayout) itemView).addView(extraText); - else ((LinearLayout) itemView).addView(extraText, 0); - text.setText(isVertical ? item.fullText : item.text); - if (item.extra != null) { - extraText.setText(isVertical ? item.extra.fullText : item.extra.text); - } } @Override diff --git a/mastodon/src/main/res/layout/display_item_reblog_or_reply_line.xml b/mastodon/src/main/res/layout/display_item_reblog_or_reply_line.xml index 58312a3f47..a810c2ebe3 100644 --- a/mastodon/src/main/res/layout/display_item_reblog_or_reply_line.xml +++ b/mastodon/src/main/res/layout/display_item_reblog_or_reply_line.xml @@ -1,5 +1,5 @@ - - \ No newline at end of file + \ No newline at end of file