Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit testing #2

Open
dpoposki opened this issue Feb 1, 2017 · 3 comments
Open

Add unit testing #2

dpoposki opened this issue Feb 1, 2017 · 3 comments
Labels
enhancement

Comments

@dpoposki
Copy link
Collaborator

dpoposki commented Feb 1, 2017

We currently have some unit tests in the library, but would be cool to have a higher coverage. We need to check if the current ones are working.
@dmanners
Copy link
Contributor

dmanners commented Feb 1, 2017

Extra infromation from Vinai:

  • Migrate to phpunit.xml.dist file from phpunit.xml
  • phpunit will use the phpunit.xml.dist in absence of the phpunit.xml. The default phpunit.xml(.dist) should not define logging targets as that is very specific to the context where and how the tests are run. So I suggest renaming phpunit.xml to phpunit.xml.dist and commenting out the logging section.

@dpoposki
Copy link
Collaborator Author

dpoposki commented Feb 8, 2017

We bumped PHPUnit minimum requirement to 5.7 in #20

@dmanners
Copy link
Contributor

dmanners commented Feb 9, 2017

Covered the renaming of phpunit.xml in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmanners @dpoposki