From e0bf9a0ccc008285c11ecb42ae785f8068fcd212 Mon Sep 17 00:00:00 2001 From: Anton Boritskiy Date: Fri, 20 Aug 2021 12:40:46 +0200 Subject: [PATCH 1/5] ADHOC fix redis-backend: use extended redis backend class magento has a new extended implementation and recomends using it since 2.3.5, see https://devdocs.magento.com/guides/v2.4/config-guide/redis/redis-pg-cache.html#new-redis-cache-implementation --- defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/main.yml b/defaults/main.yml index 71065c2..7145958 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -223,7 +223,7 @@ magento_session_save: "files" ## (Required) magento_x_frame_options: "SAMEORIGIN" -# magento_cache_frontend_page_cache_backend: "Cm_Cache_Backend_Redis" +# magento_cache_frontend_page_cache_backend: "\\Magento\\Framework\\Cache\\Backend\\Redis" ## (Required if magento_cache_frontend_page_cache_backend is used) # magento_cache_frontend_page_cache_backend_options: From 9b872504c8a8f5d702e082100cdb1bc66c25c514 Mon Sep 17 00:00:00 2001 From: Anton Boritskiy Date: Fri, 20 Aug 2021 12:41:55 +0200 Subject: [PATCH 2/5] ADHOC chore cache-config: use more compact syntax to help readability --- defaults/main.yml | 39 +++++++++++++-------------------------- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/defaults/main.yml b/defaults/main.yml index 7145958..b09ce2e 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -260,32 +260,19 @@ magento_x_frame_options: "SAMEORIGIN" ## See http://devdocs.magento.com/guides/v2.1/config-guide/config/config-php.html ## (Optional) magento_cache_types: - - name: "config" - enabled: 1 - - name: "layout" - enabled: 1 - - name: "block_html" - enabled: 1 - - name: "collections" - enabled: 1 - - name: "reflection" - enabled: 1 - - name: "db_ddl" - enabled: 1 - - name: "eav" - enabled: 1 - - name: "full_page" - enabled: 1 - - name: "config_integration" - enabled: 1 - - name: "config_integration_api" - enabled: 1 - - name: "target_rule" - enabled: 1 - - name: "translate" - enabled: 1 - - name: "config_webservice" - enabled: 1 + - {name: "config", enabled: 1} + - {name: "layout", enabled: 1} + - {name: "block_html", enabled: 1} + - {name: "collections", enabled: 1} + - {name: "reflection", enabled: 1} + - {name: "db_ddl", enabled: 1} + - {name: "eav", enabled: 1} + - {name: "full_page", enabled: 1} + - {name: "config_integration", enabled: 1} + - {name: "config_integration_api", enabled: 1} + - {name: "target_rule", enabled: 1} + - {name: "translate", enabled: 1} + - {name: "config_webservice", enabled: 1} ## During the upgrade of Magneto, there are certain commands that must be run to ensure the database is up to date ## and that content is successfully migrated. These commands are run every release, and are expected to be idempotent. From a8782629eeb0ba0425ea229ebfd851f30dbcd040 Mon Sep 17 00:00:00 2001 From: Anton Boritskiy Date: Fri, 20 Aug 2021 12:46:53 +0200 Subject: [PATCH 3/5] ADHOC fix cache-config: missing cache types those magento standard cache types were missing in our default config, see https://devdocs.magento.com/guides/v2.4/config-guide/cli/config-cli-subcommands-cache.html --- defaults/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/defaults/main.yml b/defaults/main.yml index b09ce2e..7a0b46d 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -266,7 +266,9 @@ magento_cache_types: - {name: "collections", enabled: 1} - {name: "reflection", enabled: 1} - {name: "db_ddl", enabled: 1} + - {name: "compiled_config", enabled: 1} - {name: "eav", enabled: 1} + - {name: "customer_notification", enabled: 1} - {name: "full_page", enabled: 1} - {name: "config_integration", enabled: 1} - {name: "config_integration_api", enabled: 1} From d8eec645ac036cacf109131c159bb39f5342a338 Mon Sep 17 00:00:00 2001 From: Anton Boritskiy Date: Fri, 20 Aug 2021 12:51:10 +0200 Subject: [PATCH 4/5] ADHOC chore docs: fix typo --- defaults/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defaults/main.yml b/defaults/main.yml index 7a0b46d..b2cfce5 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -276,7 +276,7 @@ magento_cache_types: - {name: "translate", enabled: 1} - {name: "config_webservice", enabled: 1} -## During the upgrade of Magneto, there are certain commands that must be run to ensure the database is up to date +## During the upgrade of Magento, there are certain commands that must be run to ensure the database is up to date ## and that content is successfully migrated. These commands are run every release, and are expected to be idempotent. magento_upgrade_commands: - "setup:upgrade --keep-generated" From 18cd79035e00313a8b4131ebc6bf08a3a31e84e0 Mon Sep 17 00:00:00 2001 From: Anton Boritskiy Date: Fri, 20 Aug 2021 12:51:41 +0200 Subject: [PATCH 5/5] ADHOC chore docs: it actualy does clean old releases --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 0f196c2..20da1b8 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,6 @@ It installs a version of Magento two from an S3 bucket in a minimal ## Limitations -- It does not currently clean up old releases. This makes each release slower, due to a recursive chown - It is not hugely portable. It was open sourced as part of an effort to make it so - It requires infrastructure tailored in a particular format, which is currently undocumented.