Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor is not updating base on the size of the text. #2169

Open
1 task done
honzaadamec opened this issue Aug 31, 2024 · 8 comments
Open
1 task done

Cursor is not updating base on the size of the text. #2169

honzaadamec opened this issue Aug 31, 2024 · 8 comments
Labels
bug Something isn't working minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function reproducible This bug has been confirmed and can be reliably reproduced.

Comments

@honzaadamec
Copy link

honzaadamec commented Aug 31, 2024

Is there an existing issue for this?

Flutter Quill version

flutter_quill: ^10.1.5

Steps to reproduce

Screenshot at Aug 31 15-35-35

I tried on different platforms as linux, windows or web for example. Same result.

The same problem is on your git repo, where you have already some example for try. Same bug/issue there.

image

I tried to somehow make it on different way. I have found that here is some option of TextStyle. But it only work for paragraph. But it affected the height of the text overall.. so this is not good solution. When I need have line spacing same on different lines.
image

The other variation for example header. It totally ignore the fontsize. And set cursor with some default height.

Expected results

Expected result is to set cursor height base on font size in attributes of the controller.

Actual results

Cursor size not updating. Or there is not easy way to handle it.

Code sample

No response

Additional Context

Related #1568

@honzaadamec honzaadamec added the bug Something isn't working label Aug 31, 2024
@ifuterman
Copy link

The same. I found CursorStyle class. But this is the parameter for a QuillRawEditor.

@Paul-creator
Copy link

I ran the example project of the repo an look at the results:

I opened Default:
Screenshot 2024-09-03 at 21 04 03

The cursor has the right size in the existing text:
Screenshot 2024-09-03 at 21 04 17
Screenshot 2024-09-03 at 21 04 28

However if i write some text and adjust the size I have the same problem as you:
Screenshot 2024-09-03 at 21 07 36

Also further down in the example, where the font changes in the line, the cursor size is wrong again:
Screenshot 2024-09-03 at 21 04 51

@EchoEllet
Copy link
Collaborator

#1688 seems to be a PR that fixes the issue that occurs on the web in the case of iOS.

Do you mean the issue itself (#1568)?

@Paul-creator
Copy link

Paul-creator commented Sep 13, 2024

He means the issue itself for sure.
Here is a little video which shows the issue in the repo using the example project.
Video on Google Drive

@EchoEllet EchoEllet changed the title Cursor is not updating base on the size of the text. - same issue as #1688 (but has been closed) Cursor is not updating base on the size of the text. Sep 13, 2024
@CatHood0
Copy link
Collaborator

I'll try to fix this when i have time. I need to fix some issues that are my priority and then i will fix this.

@CatHood0 CatHood0 added minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function reproducible This bug has been confirmed and can be reliably reproduced. labels Sep 22, 2024
@ifuterman
Copy link

Fastest fix, add a property with cursor style to the QuillEditor.

@CatHood0
Copy link
Collaborator

CatHood0 commented Sep 23, 2024

Fastest fix, add a property with cursor style to the QuillEditor.

That's could not be the best solution. Fast fixes could come with bugs or unexpected behaviors that affect to the end users. We will fix this, but, we need some time to fix other more critical issues and then we will take a look on this types of issues.

@lingyun000
Copy link

最快的修复方法是向 QuillEditor 添加具有光标样式的属性。

这可能不是最好的解决方案。快速修复可能会带来错误或影响最终用户的意外行为。我们会修复这个问题,但我们需要一些时间来解决其他更关键的问题,然后我们才会研究这类问题。

Custom embed causes the cursor to become very large, and when scrolling beyond the screen, clicking makes it switch positions back and forth. Can you take a look at this together?

Kapture.2024-09-27.at.16.25.03.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor Minimal impact or cosmetic issue. Can be resolved at a later time without affecting overall function reproducible This bug has been confirmed and can be reliably reproduced.
Projects
None yet
Development

No branches or pull requests

6 participants