-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary scroll to the cursor when checking/unchecking a checkbox #1975
Comments
@singerdmx , could you please take a look since it looks similar to #619 you've fixed? |
It's weird @singerdmx say this issue is fixed. This is the commit: 7bd494a |
It might be a regression caused by another change, or it fixes it with a specific use case. |
The changes from the commit are still applied, however, it is in |
The changes have a comment that says it's a workaround, it's looks like some other change affects how this workaround fixed it, which is generally one reason why we need more tests. |
II contributed for a short period of time to AppFlowy-editor, and for every little new feature or fix, a test was done to make sure everything did what it should. They even have documentation about testing. I think we should start creating more tests about the package's functionalities. It would be good to have documentation about testing in this package, because for my part, I do not understand 100% how to test most of the package's functionalities. |
I prefer to continue this discussion on Slack or GitHub Discussions or maybe with a different issue, as it’s not directly related to the technical aspects of this report. To keep the issue report focused on the bug itself, including related bugs, fixes, and potential workarounds |
Is there an existing issue for this?
Flutter Quill version
master
Steps to reproduce
Expected results
No scrolling happens.
Actual results
The editor scrolls to the cursor.
Code sample
Code sample
[Paste your code here]
Screenshots or Video
Screenshots / Video demonstration
checkbox-scrolling-bug.mp4
Logs
Logs
[Paste your logs here]
The text was updated successfully, but these errors were encountered: