Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary scroll to the cursor when checking/unchecking a checkbox #1975

Open
1 task done
Alspb opened this issue Jul 5, 2024 · 7 comments
Open
1 task done

Unnecessary scroll to the cursor when checking/unchecking a checkbox #1975

Alspb opened this issue Jul 5, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@Alspb
Copy link
Contributor

Alspb commented Jul 5, 2024

Is there an existing issue for this?

Flutter Quill version

master

Steps to reproduce

  1. Place the cursor somewhere.
  2. Hide the keyboard.
  3. Scroll to some checkbox and check/uncheck it.

Expected results

No scrolling happens.

Actual results

The editor scrolls to the cursor.

Code sample

Code sample
[Paste your code here]

Screenshots or Video

Screenshots / Video demonstration
checkbox-scrolling-bug.mp4

Logs

Logs
[Paste your logs here]
@Alspb Alspb added the bug Something isn't working label Jul 5, 2024
@Alspb
Copy link
Contributor Author

Alspb commented Jul 5, 2024

@singerdmx , could you please take a look since it looks similar to #619 you've fixed?

@CatHood0
Copy link
Collaborator

CatHood0 commented Jul 7, 2024

It's weird @singerdmx say this issue is fixed. This is the commit: 7bd494a

@EchoEllet
Copy link
Collaborator

It's weird @singerdmx say this issue is fixed. This is the commit: 7bd494a

It might be a regression caused by another change, or it fixes it with a specific use case.

@CatHood0
Copy link
Collaborator

CatHood0 commented Jul 8, 2024

It might be a regression caused by another change, or it fixes it with a specific use case.

The changes from the commit are still applied, however, it is in raw_editor_state where they are now. Anyway, it seems that it only temporarily fixed the bug during those versions

@EchoEllet
Copy link
Collaborator

The changes have a comment that says it's a workaround, it's looks like some other change affects how this workaround fixed it, which is generally one reason why we need more tests.

@CatHood0
Copy link
Collaborator

CatHood0 commented Jul 8, 2024

The changes have a comment that says it's a workaround, it's looks like some other change affects how this workaround fixed it, which is generally one reason why we need more tests

II contributed for a short period of time to AppFlowy-editor, and for every little new feature or fix, a test was done to make sure everything did what it should. They even have documentation about testing. I think we should start creating more tests about the package's functionalities. It would be good to have documentation about testing in this package, because for my part, I do not understand 100% how to test most of the package's functionalities.

@EchoEllet
Copy link
Collaborator

EchoEllet commented Jul 8, 2024

I prefer to continue this discussion on Slack or GitHub Discussions or maybe with a different issue, as it’s not directly related to the technical aspects of this report.

To keep the issue report focused on the bug itself, including related bugs, fixes, and potential workarounds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants