Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletes lines of insert_final_newline = false #78

Open
gserrg opened this issue Mar 6, 2019 · 3 comments
Open

Deletes lines of insert_final_newline = false #78

gserrg opened this issue Mar 6, 2019 · 3 comments

Comments

@gserrg
Copy link

gserrg commented Mar 6, 2019

This parameter should not delete lines, it is only to add them.

insert_final_newline: set to true to ensure file ends with a newline when saving and false to ensure it doesn't

see editorconfig/editorconfig#269

@sindresorhus
Copy link
Owner

#44

@gserrg
Copy link
Author

gserrg commented Mar 6, 2019

#44

Yes, you broke the plugin

@gserrg
Copy link
Author

gserrg commented Mar 6, 2019

In accordance with the editorconfig documentation, this option only requires adding lines, it does not require removal. See the discussion for relevant issues https://github.com/editorconfig/editorconfig/issues/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants