You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've just implemented a cache in simple-icons SVG linting rules to avoid parsing the same data for the same files over and over again (see simple-icons/simple-icons#9233) which gives a great performance improvement.
As this case is very common due the fact that SVGLint executes all function rules for the same set of files I think that could be added to the configuration by some hook or something like that. The implementation could be a function executed for each file before rules and some API added to function rules arguments to obtain the values.
Some thoughs about this?
The text was updated successfully, but these errors were encountered:
I think this makes sense, I would not be entirely sure what this would look like in the API though 🤔 Do you have something in mind @mondeja, or do you know of some examples from other tooling?
Also, would you be interested in working on this? If so I can assign the issue to you and I'd be happy to review your work.
I'll try to find other tools with this pattern before design the API, as I don't remember myself now see it ever 🤔 In that case I'll implement it, for sure.
I've just implemented a cache in simple-icons SVG linting rules to avoid parsing the same data for the same files over and over again (see simple-icons/simple-icons#9233) which gives a great performance improvement.
As this case is very common due the fact that SVGLint executes all function rules for the same set of files I think that could be added to the configuration by some hook or something like that. The implementation could be a function executed for each file before rules and some API added to function rules arguments to obtain the values.
Some thoughs about this?
The text was updated successfully, but these errors were encountered: