Inconsistencies of icons includes in releases and release notes

[mondeja]

• Google Chronicle (Chronicle simple-icons#10548) was added on v11.8.0 but the release note indicates that was included on v11.9.0. You can see https://cdn.jsdelivr.net/npm/[email protected]/icons/googlechronicle.svg
• Li-Ning (Add Li-Ning Icon simple-icons#10544) has been included two times in release notes, in v11.8.0 and v11.9.0 but was really added on v11.8.0, see https://cdn.jsdelivr.net/npm/[email protected]/icons/lining.svg

[mondeja]

I've manually updated release notes.

[LitoMore]

The Google Chronicle was added in https://cdn.jsdelivr.net/npm/[email protected]/icons/googlechronicle.svg. I created this 11.8.0 release note manually; I may have missed something on my local.

Here is the code how fetching PRs:

const { data: prs } = await client.rest.pulls.list({
  owner: context.repo.owner,
  repo: context.repo.repo,
  state: 'closed',
  sort: 'updated',
  direction: 'desc',
  per_page: perPage,
  page,
});

Pull request order may changed by our comment, re-title, and other actions. Here is a similar pull request:

• Publish 26 new icons and 4 updated icon simple-icons#10436

I think our create.js needs to be refactored. We had a conversation on our discord release-action channel. I'm checking if we can use GitHub GraphQL API to get the related PR on a commit.

For example:

query {
  repository(owner: "simple-icons", name: "simple-icons") {
    defaultBranchRef {
      target {
        ... on Commit {
          history(first: 20) {
            edges {
              node {
                oid
                message
                associatedPullRequests(first: 1) {
                  edges {
                    node {
                      title
                      url
                      number
                    }
                  }
                }
              }
            }
          }
        }
      }
    }
  }
}