Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][Dependency] When no content is found but range is meaningful, return code should be 204 #338

Open
ppom0 opened this issue Mar 6, 2020 · 2 comments
Open

[API][Dependency] When no content is found but range is meaningful, return code should be 204 #338

ppom0 opened this issue Mar 6, 2020 · 2 comments
Labels
api Concerns the API invalid This doesn't seem right not-urgent-issue Has to be fixed, but doesn't prevent from using the app. Not to be mistaken for not-urgent-feature

Comments

@ppom0
Copy link
Contributor

ppom0 commented Mar 6, 2020

When no content is found, the 416 HTTP Error Code is returned.
4xx means a client error.
If the request was correctly understood and processed, the 204 HTTP Success Code should be returned.
This last HTTP Code doesn't cause a JS exception!
@ppom0 ppom0 added invalid This doesn't seem right not-urgent-issue Has to be fixed, but doesn't prevent from using the app. Not to be mistaken for not-urgent-feature api Concerns the API labels Mar 6, 2020
@MercierCorentin
Copy link
Contributor

This is due to this package https://github.com/NastuzziSamy/laravel-query-selector. Closing this issue for a new one on Samy's repo.

@MercierCorentin
Copy link
Contributor

Re-opening to remember updating front-end after this PR's merge.

@MercierCorentin MercierCorentin changed the title [API] When no content is found but range is meaningful, return code should be 204 [Dependency] When no content is found but range is meaningful, return code should be 204 Mar 12, 2020
@MercierCorentin MercierCorentin changed the title [Dependency] When no content is found but range is meaningful, return code should be 204 [API][Dependency] When no content is found but range is meaningful, return code should be 204 Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Concerns the API invalid This doesn't seem right not-urgent-issue Has to be fixed, but doesn't prevent from using the app. Not to be mistaken for not-urgent-feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppom0 @MercierCorentin