Problems Skipping Sponsors with Increased Playback Speed!

[INFINITY1001]

Hi,

First thanks for the amazing Sponsor Block application for Kodi! Love using it! I found a problem/bug where the sponsors don't skip when the playback speed is increased. In Kodi 19 Matrix playback speed was introduced. I believe it supports all the way up to 1.5x playback speed. Once the playback speed is increased (tempo/up) the sponsors no longer skip. If we return the speed back to 1x the sponsors skip perfectly fine.

Thanks for your amazing work, not sure your still working on this project. Will continue to use regardless.

Kind regards!

[siku2]

I don't have the time to look into this myself, so I'm just dropping a few pointers for someone else to get started.

The addon is supposed to take this into account, you can see the playback_speed factoring into the equation here:

script.service.sponsorblock/resources/lib/utils/checkpoint_listener.py

Line 53 in e9ba63b

wait_for = (target_time - self.getTime()) / self._playback_speed

I remember testing this on Kodi 18 and it used to work, but there have been some other changes since then, so not sure why it's no longer working.
One place to look into would be this callback:

script.service.sponsorblock/resources/lib/utils/checkpoint_listener.py

Lines 203 to 205 in e9ba63b

	def onPlayBackSpeedChanged(self, speed): # type: (int) -> None
	self._playback_speed = float(speed)
	self._trigger_wakeup()

I assume the playback_speed variable is simply no longer synchronized with the player's actual playback speed.