Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate JSON creation rule for zero account as recipient #724

Open
frankTheTank72 opened this issue Mar 3, 2023 · 3 comments
Open

Comments

@frankTheTank72
Copy link
Member

frankTheTank72 commented Mar 3, 2023

If a JSON is created we have the following check for the zero account:

grafik

In this case, the receiver is not set in the JSON message.
We should check if we can remove this check, as this JSON is also used to propagate messages between nodes.

@frankTheTank72 frankTheTank72 changed the title Investigate JSON creation rule for zero account Investigate JSON creation rule for zero account as recipient Mar 3, 2023
@ohager
Copy link
Member

ohager commented Jan 3, 2024

So, you potentially want to check, if something is burnt? 🔥

I have a potential solution: If recipient Id = 0 we set a flag burnt=true, so no compatibility issue then.

@damccull
Copy link
Collaborator

What problems does this actually cause, and, more importantly, where is it in the code? I'm curious what this is for. Judging from @ohager's comment, it's a check to burn signa, but there's no context in this issue.

@frankTheTank72
Copy link
Member Author

frankTheTank72 commented Jan 28, 2024

yep lost the context also - sh...
I think something with the node comunication ... but maybe @jjos2372 rembers it... sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants